Revision: 41778
          http://brlcad.svn.sourceforge.net/brlcad/?rev=41778&view=rev
Author:   indianlarry
Date:     2010-12-22 17:18:04 +0000 (Wed, 22 Dec 2010)

Log Message:
-----------
Valgrind squelch - valgrind reporting read error on the dm_list member dml_dmp 
from function doEvent(). The problem is that the display manager pointer 
'dml_dmp' was being free'd from DM_CLOSE() but the parent list element(struct 
dm_list) was not being dequeued or removed in mged_finish() and would turn up 
in the event loop after being free'd 

Modified Paths:
--------------
    brlcad/trunk/src/mged/mged.c

Modified: brlcad/trunk/src/mged/mged.c
===================================================================
--- brlcad/trunk/src/mged/mged.c        2010-12-22 15:40:34 UTC (rev 41777)
+++ brlcad/trunk/src/mged/mged.c        2010-12-22 17:18:04 UTC (rev 41778)
@@ -2518,12 +2518,17 @@
     log_event("CEASE", place);
 
     /* Release all displays */
-    FOR_ALL_DISPLAYS(p, &head_dm_list.l) {
-       curr_dm_list = p;
+    struct dm_list *dml;
+    while (BU_LIST_WHILE(p, dm_list, &(head_dm_list.l))) {
+       BU_LIST_DEQUEUE(&(p->l));
+       if (p && p->dml_dmp) {
+           DM_CLOSE(p->dml_dmp);
+       }
 
-       if (curr_dm_list && dmp) {
-           DM_CLOSE(dmp);
-       }
+       RT_FREE_VLIST(&p->dml_p_vlist);
+       mged_slider_free_vls(p);
+       bu_free((genptr_t) p, "release: curr_dm_list");
+       curr_dm_list = DM_LIST_NULL;
     }
 
     for (BU_LIST_FOR (c, cmd_list, &head_cmd_list.l)) {


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Forrester recently released a report on the Return on Investment (ROI) of
Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
within 7 months.  Over 3 million businesses have gone Google with Google Apps:
an online email calendar, and document program that's accessible from your 
browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to