Revision: 42460
          http://brlcad.svn.sourceforge.net/brlcad/?rev=42460&view=rev
Author:   brlcad
Date:     2011-01-19 18:33:28 +0000 (Wed, 19 Jan 2011)

Log Message:
-----------
wow, now that I can finally reproduce and investigate ... FIX the 
several-year-old bug where compilation would fail on some Mac OS X systems 
(10.6+?) with a 'dyld: Library not loaded: 
/usr/brlcad/dev-7.18.1//lib/libwdb.19.dylib' message (and subsequent crash 
report).  the problem is actually due to a bug in libtool where their 
temp_rpath variable was getting appended to another path variable but without a 
: between the two path sets.  we patch libtool due to a separate -all_load bug 
where temp_rpath was getting set to 'TCL_PATH:' causing a bad DYLD_LIBRARY_PATH 
in the resulting libtool wrapper script for asc2g.  the fix could have been as 
simple as add a trailing colon manually, but instead I'm just going to remove 
the line since 1) TCL/TK path logic shouldn't be in this file and 2) the commit 
history nor file indicate why that line is patched, and most importantly 3) it 
works on 10.6 and libtool 2.2.4 without it.  long overdue.

Modified Paths:
--------------
    brlcad/trunk/NEWS
    brlcad/trunk/m4/patch.m4

Modified: brlcad/trunk/NEWS
===================================================================
--- brlcad/trunk/NEWS   2011-01-19 18:02:22 UTC (rev 42459)
+++ brlcad/trunk/NEWS   2011-01-19 18:33:28 UTC (rev 42460)
@@ -13,6 +13,7 @@
 --- 2010-12-XX  Release 7.18.2                                     ---
 ----------------------------------------------------------------------
 
+* fixed Mac build failure running asc2g before install - Sean Morrison
 * fixed g_diff color table difference false positive - Sean Morrison
 * fixed asc2g color table bug parsing 'color' lines - Sean Morrison
 * 'attr show' command displays attributes sorted by name - Tom Browder

Modified: brlcad/trunk/m4/patch.m4
===================================================================
--- brlcad/trunk/m4/patch.m4    2011-01-19 18:02:22 UTC (rev 42459)
+++ brlcad/trunk/m4/patch.m4    2011-01-19 18:33:28 UTC (rev 42460)
@@ -60,7 +60,6 @@
                # provokes libtool linker bug with noinst libraries.
                darwin*)
                    sed 's/-all_load.*convenience//g' < $libtoolscript > 
${libtoolscript}.sed
-                   sed "s/temp_rpath=\$/temp_rpath=$TCL_PATH:$TK_PATH/g" < 
$libtoolscript.sed > ${libtoolscript}.sed2
                    if test ! "x`cat ${libtoolscript}`" = "x`cat 
${libtoolscript}.sed2`" ; then
                        AC_MSG_RESULT([Found -all_load in libtool script, 
removing])
                        cp ${libtoolscript}.sed2 ${libtoolscript}


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to