Revision: 57072
          http://sourceforge.net/p/brlcad/code/57072
Author:   starseeker
Date:     2013-08-22 18:47:37 +0000 (Thu, 22 Aug 2013)
Log Message:
-----------
tweaks - geometry still not coming in correctly with BRL-CAD step-g, looks like 
topology is off somewhere...

Modified Paths:
--------------
    brlcad/trunk/src/conv/step/g-step/ON_Brep.cpp

Modified: brlcad/trunk/src/conv/step/g-step/ON_Brep.cpp
===================================================================
--- brlcad/trunk/src/conv/step/g-step/ON_Brep.cpp       2013-08-22 18:34:13 UTC 
(rev 57071)
+++ brlcad/trunk/src/conv/step/g-step/ON_Brep.cpp       2013-08-22 18:47:37 UTC 
(rev 57072)
@@ -179,6 +179,7 @@
        /* Add knot */
        RealNode *knot = new RealNode();
        knot->value = insrf->Knot(0, i);
+       std::cout << "Knot value(0,i): " << knot->value << "\n";
        u_knots->AddNode(knot);
 
        /* OpenNURBS and STEP have different notions of end knot
@@ -201,6 +202,7 @@
        /* Add knot */
        RealNode *knot = new RealNode();
        knot->value = insrf->Knot(1, i);
+       std::cout << "Knot value(1,i): " << knot->value << "\n";
        v_knots->AddNode(knot);
 
        /* OpenNURBS and STEP have different notions of end knot multiplicity -
@@ -742,7 +744,6 @@
            curr_surface->surface_form_(B_spline_surface_form__plane_surf);
            /* Planes don't self-intersect */
            curr_surface->self_intersect_(LFalse);
-           /* TODO - need to recognize when these should be true */
            curr_surface->u_closed_(LFalse);
            curr_surface->v_closed_(LFalse);
            instance_list->Append(surfaces.at(i), completeSE);
@@ -768,9 +769,8 @@
            curr_surface->surface_form_(B_spline_surface_form__unspecified);
            /* TODO - for now, assume the surfaces don't self-intersect - need 
to figure out how to test this */
            curr_surface->self_intersect_(LFalse);
-           /* TODO - need to recognize when these should be true */
-           curr_surface->u_closed_(LFalse);
-           curr_surface->v_closed_(LFalse);
+           curr_surface->u_closed_((Logical)n_surface->IsClosed(0));
+           curr_surface->v_closed_((Logical)n_surface->IsClosed(1));
            instance_list->Append(surfaces.at(i), completeSE);
            surface_converted = 1;
        }
@@ -797,9 +797,8 @@
            curr_surface->surface_form_(B_spline_surface_form__plane_surf);
            /* TODO - for now, assume non-self-intersecting */
            curr_surface->self_intersect_(LFalse);
-           /* TODO - need to recognize when these should be true */
-           curr_surface->u_closed_(LFalse);
-           curr_surface->v_closed_(LFalse);
+           curr_surface->u_closed_((Logical)sum_surface->IsClosed(0));
+           curr_surface->v_closed_((Logical)sum_surface->IsClosed(1));
            instance_list->Append(surfaces.at(i), completeSE);
            surface_converted = 1;
        }
@@ -831,7 +830,7 @@
                instance_list->Append(outer_bound, completeSE);
                outer_bound->bound_((SdaiLoop 
*)edge_loops.at(curr_loop->m_loop_index));
                // TODO - When should this be false?
-               outer_bound->orientation_(BTrue);
+               outer_bound->orientation_(BFalse);
                bounds->AddNode(new EntityNode((SDAI_Application_instance 
*)outer_bound));
            } else {
                SdaiFace_bound *inner_bound = (SdaiFace_bound 
*)registry->ObjCreate("FACE_BOUND");

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to