Revision: 70686
          http://sourceforge.net/p/brlcad/code/70686
Author:   starseeker
Date:     2018-02-08 12:55:26 +0000 (Thu, 08 Feb 2018)
Log Message:
-----------
we want quick/hard failure if any of the make commands fail.

Modified Paths:
--------------
    brlcad/trunk/misc/clang-static-analyzer-run.sh

Modified: brlcad/trunk/misc/clang-static-analyzer-run.sh
===================================================================
--- brlcad/trunk/misc/clang-static-analyzer-run.sh      2018-02-08 12:33:32 UTC 
(rev 70685)
+++ brlcad/trunk/misc/clang-static-analyzer-run.sh      2018-02-08 12:55:26 UTC 
(rev 70686)
@@ -1,8 +1,19 @@
 #!/bin/bash
+
+# We want the script to fail hard and immediately if anything goes wrong, in
+# order to avoid masking failures (e.g. build failures, which will leave
+# empty scan reports but certainly don't constitute successes. See (for 
example)
+# https://stackoverflow.com/q/821396
+set -e
+set -o pipefail
+
 export CCC_CC=clang
 export CCC_CXX=clang++
 
-# TODO - test if this is a valid way to enable the new Z3 static analyzer 
support...
+# This appears to be a workable way to enable the new Z3 static analyzer
+# support, but at least as of 2017-12 it greatly slows the testing (by orders
+# of magnitude).  Might be viable (or at least more useful even if it can't
+# quickly complete) if we completely pre-build src/other
 #export CCC_ANALYZER_CONSTRAINTS_MODEL=z3
 
 expected_success=()
@@ -85,7 +96,7 @@
 cleantest libfft
 failingtest libtclcad
 cleantest libtermio
-failingtest libremrt
+cleantest libremrt
 cleantest librender
 
 # Executables

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to