Revision: 73799
          http://sourceforge.net/p/brlcad/code/73799
Author:   starseeker
Date:     2019-08-30 18:37:44 +0000 (Fri, 30 Aug 2019)
Log Message:
-----------
Stress the importance of getting this piece correct - was hard to run down from 
the graphically observed errors.

Modified Paths:
--------------
    brlcad/trunk/src/libbrep/cdt2.cpp

Modified: brlcad/trunk/src/libbrep/cdt2.cpp
===================================================================
--- brlcad/trunk/src/libbrep/cdt2.cpp   2019-08-30 18:32:16 UTC (rev 73798)
+++ brlcad/trunk/src/libbrep/cdt2.cpp   2019-08-30 18:37:44 UTC (rev 73799)
@@ -596,7 +596,13 @@
        poly2_ne2->eseg = bseg2;
     }
 
-    // The new trim segments are then associated with the new bounding edge 
segments
+    // The new trim segments are then associated with the new bounding edge
+    // segments.
+    // NOTE: the m_bRev3d logic below is CRITICALLY important when it comes to
+    // associating the correct portion of the edge curve with the correct part
+    // of the polygon in parametric space.  If this is NOT correct, the 3D
+    // polycurves manifested by the 2D polygon will be self intersecting, as
+    // will the 3D triangles generated from the 2D CDT.
     bseg1->tseg1 = (trim1->m_bRev3d) ? poly1_ne2 : poly1_ne1;
     bseg1->tseg2 = (trim2->m_bRev3d) ? poly2_ne2 : poly2_ne1;
     bseg2->tseg1 = (trim1->m_bRev3d) ? poly1_ne1 : poly1_ne2;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to