Revision: 75461
          http://sourceforge.net/p/brlcad/code/75461
Author:   starseeker
Date:     2020-04-18 13:04:56 +0000 (Sat, 18 Apr 2020)
Log Message:
-----------
Use explicit buffer sizes - sizeof isn't right in that context

Modified Paths:
--------------
    brlcad/trunk/src/libtermio/termcap.c
    brlcad/trunk/src/libtermio/tgoto.c

Modified: brlcad/trunk/src/libtermio/termcap.c
===================================================================
--- brlcad/trunk/src/libtermio/termcap.c        2020-04-18 13:00:21 UTC (rev 
75460)
+++ brlcad/trunk/src/libtermio/termcap.c        2020-04-18 13:04:56 UTC (rev 
75461)
@@ -154,7 +154,7 @@
                }
                hopcount--;
                tbuf = holdtbuf;
-               bu_strlcpy(rmbuf, &p[1], sizeof(&p[1]));
+               bu_strlcpy(rmbuf, &p[1], TCBUFSIZE);
                for (q=tcbuf; *q != ':'; q++)
                        ;
                l = holdtc - holdtbuf + strlen(rmbuf) + strlen(q);
@@ -165,7 +165,7 @@
                q++;
                for (p = holdtc; *q; q++)
                        *p++ = *q;
-               bu_strlcpy(p, rmbuf, sizeof(rmbuf));
+               bu_strlcpy(p, rmbuf, TCBUFSIZE);
                p = holdtc;
        }
        return(1);
@@ -203,7 +203,7 @@
                        c = tnamatch(name);
                        tbuf = bp;
                        if (c) {
-                               bu_strlcpy(bp, cp, sizeof(cp));
+                               bu_strlcpy(bp, cp, TCBUFSIZE);
                                return(tnchktc());
                        }
                }

Modified: brlcad/trunk/src/libtermio/tgoto.c
===================================================================
--- brlcad/trunk/src/libtermio/tgoto.c  2020-04-18 13:00:21 UTC (rev 75460)
+++ brlcad/trunk/src/libtermio/tgoto.c  2020-04-18 13:04:56 UTC (rev 75461)
@@ -213,6 +213,6 @@
                        goto toohard;
                }
        }
-       bu_strlcpy(dp, added, sizeof(added));
+       bu_strlcpy(dp, added, MAXRETURNSIZE);
        return (result);
 }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to