Revision: 75705
http://sourceforge.net/p/brlcad/code/75705
Author: starseeker
Date: 2020-05-06 13:00:38 +0000 (Wed, 06 May 2020)
Log Message:
-----------
checkpoint (WIP, not functional)
Modified Paths:
--------------
brlcad/trunk/regress/CMakeLists.txt
Added Paths:
-----------
brlcad/trunk/regress/repository/
brlcad/trunk/regress/repository/CMakeLists.txt
brlcad/trunk/regress/repository/regress-repository.cmake
brlcad/trunk/regress/repository/repocheck.cpp
Modified: brlcad/trunk/regress/CMakeLists.txt
===================================================================
--- brlcad/trunk/regress/CMakeLists.txt 2020-05-06 09:36:40 UTC (rev 75704)
+++ brlcad/trunk/regress/CMakeLists.txt 2020-05-06 13:00:38 UTC (rev 75705)
@@ -64,6 +64,9 @@
# License check
add_subdirectory(licenses)
+# Repository check
+add_subdirectory(repository)
+
if(SH_EXEC)
macro(Sh_Regression_Test testname depends_list)
CMAKE_PARSE_ARGUMENTS(${testname} "EXCLUDE_FROM_REGRESS" "" "" ${ARGN})
Added: brlcad/trunk/regress/repository/CMakeLists.txt
===================================================================
--- brlcad/trunk/regress/repository/CMakeLists.txt
(rev 0)
+++ brlcad/trunk/regress/repository/CMakeLists.txt 2020-05-06 13:00:38 UTC
(rev 75705)
@@ -0,0 +1,54 @@
+if (DEFINED REPOCHECK_TEST)
+ add_executable(repocheck repocheck.cpp)
+ if (O3_COMPILER_FLAG)
+ # This check benefits greatly from optimization. If we have the O3 flag,
use
+ # it - whether or not the standard build settings would add it.
+ target_compile_options(lcheck PRIVATE "-O3")
+ endif (O3_COMPILER_FLAG)
+ set_target_properties(repocheck PROPERTIES FOLDER "BRL-CAD Regression Tests")
+
+
+ set(LOG_FILE "${CMAKE_CURRENT_BINARY_DIR}/regress-repository.log")
+ set(STAMP_FILE "${CMAKE_CURRENT_BINARY_DIR}/regress-repository.done")
+ set(ALL_FILES_LIST "${BRLCAD_BINARY_DIR}/cmakefiles.cmake")
+
+ add_custom_command(
+ OUTPUT "${STAMP_FILE}"
+ COMMAND "${CMAKE_COMMAND}"
+ -DLCHECK_EXEC="$<TARGET_FILE:repocheck>"
+ -DL_FILE="${LOG_FILE}" -DS_FILE="${STAMP_FILE}"
-DF_LIST="${ALL_FILES_LIST}"
+ -P "${CMAKE_CURRENT_SOURCE_DIR}/regress-repository.cmake"
+ )
+ add_custom_target(regress-repository DEPENDS ${STAMP_FILE}
${CMAKE_BINARY_DIR}/embedded_repository.txt)
+ set_target_properties(regress-repository PROPERTIES FOLDER "BRL-CAD
Regression Tests")
+ add_dependencies(regress regress-repository)
+ add_dependencies(check regress-repository)
+
+ add_test(NAME regress-repository
+ COMMAND "${CMAKE_COMMAND}"
+ -DLCHECK_EXEC=$<TARGET_FILE:repocheck>
+ -DL_FILE=${LOG_FILE} -DS_FILE=${STAMP_FILE} -DF_LIST=${ALL_FILES_LIST}
+ -DW_DIR=${CMAKE_CURRENT_BINARY_DIR}
+ -P "${CMAKE_CURRENT_SOURCE_DIR}/regress-repository.cmake"
+ )
+ set_tests_properties(regress-repository PROPERTIES LABELS "Regression")
+
+ DISTCLEAN(
+ ${STAMP_FILE}
+ ${LOG_FILE}
+ )
+
+ set_target_properties(regress-repository PROPERTIES
EXCLUDE_FROM_DEFAULT_BUILD 1)
+endif (DEFINED REPOCHECK_TEST)
+
+CMAKEFILES(
+ CMakeLists.txt
+ repocheck.cpp
+ regress-repository.cmake
+ )
+# Local Variables:
+# tab-width: 8
+# mode: cmake
+# indent-tabs-mode: t
+# End:
+# ex: shiftwidth=2 tabstop=8
Property changes on: brlcad/trunk/regress/repository/CMakeLists.txt
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: brlcad/trunk/regress/repository/regress-repository.cmake
===================================================================
--- brlcad/trunk/regress/repository/regress-repository.cmake
(rev 0)
+++ brlcad/trunk/regress/repository/regress-repository.cmake 2020-05-06
13:00:38 UTC (rev 75705)
@@ -0,0 +1,29 @@
+set(REPOSITORY_CHECK_EXEC "${LCHECK_EXEC}")
+set(FILES_LIST "${F_LIST}")
+set(LOG_FILE "${L_FILE}")
+set(STAMP_FILE "${S_FILE}")
+
+file(WRITE "${LOG_FILE}" "Running repository check:\n${REPOSITORY_CHECK_EXEC}
${REPOSITORY_FILE_SET} ${FILES_LIST}\n")
+message("Processing...")
+execute_process(
+ COMMAND "${REPOSITORY_CHECK_EXEC}" "${FILES_LIST}" RESULT_VARIABLE
repository_result
+ OUTPUT_VARIABLE repository_log ERROR_VARIABLE repository_log
+ WORKING_DIRECTORY ${WORKING_DIR}
+ )
+message("Processing... done.")
+
+file(APPEND "${LOG_FILE}" "\n${repository_log}\n")
+
+if(repository_result)
+ file(APPEND "${LOG_FILE}" "\n\nError: return code ${repository_result}")
+ message(FATAL_ERROR "[repository check] Failure, see ${LOG_FILE} for more
info.\n")
+else(repository_result)
+ execute_process(COMMAND "${CMAKE_COMMAND}" -E touch "${STAMP_FILE}")
+endif(repository_result)
+
+# Local Variables:
+# tab-width: 8
+# mode: cmake
+# indent-tabs-mode: t
+# End:
+# ex: shiftwidth=2 tabstop=8
Property changes on: brlcad/trunk/regress/repository/regress-repository.cmake
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:executable
## -0,0 +1 ##
+*
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: brlcad/trunk/regress/repository/repocheck.cpp
===================================================================
--- brlcad/trunk/regress/repository/repocheck.cpp
(rev 0)
+++ brlcad/trunk/regress/repository/repocheck.cpp 2020-05-06 13:00:38 UTC
(rev 75705)
@@ -0,0 +1,600 @@
+/* R E P O C H E C K . C P P
+ * BRL-CAD
+ *
+ * Copyright (c) 2008-2020 United States Government as represented by
+ * the U.S. Army Research Laboratory.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following
+ * disclaimer in the documentation and/or other materials provided
+ * with the distribution.
+ *
+ * 3. The name of the author may not be used to endorse or promote
+ * products derived from this software without specific prior written
+ * permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS
+ * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+ * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+ * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+/** @file repocheck.cpp
+ *
+ * Basic checks of the repository sources to make sure maintenance
+ * burden code clean-up problems don't creep in.
+ *
+ */
+
+#include <cstdio>
+#include <fstream>
+#include <iomanip>
+#include <iostream>
+#include <regex>
+#include <set>
+#include <map>
+#include <sstream>
+#include <string>
+#define MAX_LINES_CHECK 500
+
+bool
+priv_includes_public_hdrs(std::string &log, std::vector<std::string> &hdrs)
+{
+ bool have_private = false;
+ std::regex inc_regex("#[[:space:]]*include.*");
+
+ const char *private_hdr_filters[] {
+ ".*\"bio.h\".*",
+ ".*\"bnetwork.h\".*",
+ ".*\"bsocket.h\".*",
+ NULL
+ };
+
+ std::map<std::string, std::regex> filters;
+ int cnt = 0;
+ const char *rf = private_hdr_filters[cnt];
+ while (rf) {
+ filters[std::string(rf)] = std::regex(rf);
+ cnt++;
+ rf = private_hdr_filters[cnt];
+ }
+
+ for (size_t i = 0; i < hdrs.size(); i++) {
+ std::string sline;
+ std::ifstream fs;
+ fs.open(hdrs[i]);
+ if (!fs.is_open()) {
+ std::cerr << "Unable to open " << hdrs[i] << " for reading,
skipping\n";
+ continue;
+ }
+
+ int lcnt = 0;
+ while (std::getline(fs, sline) && lcnt < MAX_LINES_CHECK) {
+ lcnt++;
+ if (!std::regex_match(sline, inc_regex)) {
+ continue;
+ }
+ std::map<std::string, std::regex>::iterator r_it;
+ for (r_it = filters.begin(); r_it != filters.end(); r_it++) {
+ if (std::regex_match(sline, r_it->second)) {
+ have_private = true;
+ std::string lstr = std::string("Public header ") + hdrs[i]
+ std::string(" matches private header regex ") + r_it->first + std::string("
at line ") + std::to_string(lcnt) + std::string("\n");
+ log.append(lstr);
+ }
+ }
+ }
+
+ }
+
+ return have_private;
+}
+
+bool
+bio_redundant_check(std::string &log, std::vector<std::string> &srcs)
+{
+ bool ret = false;
+ std::regex bio_regex("#[[:space:]]*include[[:space:]]*\"bio.h\".*");
+ std::regex inc_regex("#[[:space:]]*include.*");
+ const char *redundant_filters[] {
+ ".*<stdio.h>.*",
+ ".*<windows.h>.*",
+ ".*<io.h>.*",
+ ".*<unistd.h>.*",
+ ".*<fcntl.h>.*",
+ NULL
+ };
+
+ std::map<std::string, std::regex> filters;
+ int cnt = 0;
+ const char *rf = redundant_filters[cnt];
+ while (rf) {
+ filters[std::string(rf)] = std::regex(rf);
+ cnt++;
+ rf = redundant_filters[cnt];
+ }
+
+
+ for (size_t i = 0; i < srcs.size(); i++) {
+ std::string sline;
+
+ std::map<std::string, std::set<int>> match_line_nums;
+
+ std::ifstream fs;
+ fs.open(srcs[i]);
+ if (!fs.is_open()) {
+ std::cerr << "Unable to open " << srcs[i] << " for reading,
skipping\n";
+ continue;
+ }
+
+ int lcnt = 0;
+ bool have_bio = false;
+ while (std::getline(fs, sline) && lcnt < MAX_LINES_CHECK) {
+ lcnt++;
+ if (std::regex_match(sline, bio_regex)) {
+ have_bio = true;
+ continue;
+ }
+
+ std::map<std::string, std::regex>::iterator f_it;
+ for (f_it = filters.begin(); f_it != filters.end(); f_it++) {
+ if (std::regex_match(sline, f_it->second)) {
+ match_line_nums[f_it->first].insert(lcnt);
+ continue;
+ }
+ }
+ }
+
+ if (have_bio) {
+ std::map<std::string, std::set<int>>::iterator m_it;
+ for (m_it = match_line_nums.begin(); m_it != match_line_nums.end();
m_it++) {
+ if (m_it->second.size()) {
+ std::set<int>::iterator l_it;
+ ret = true;
+ for (l_it = m_it->second.begin(); l_it !=
m_it->second.end(); l_it++) {
+ std::string lstr = srcs[i] + std::string(" has bio.h,
but also matches regex ") + m_it->first + std::string(" on line ") +
std::to_string(lcnt) + std::string("\n");
+ log.append(lstr);
+ }
+ }
+ }
+ }
+ }
+
+ return ret;
+}
+
+bool
+bnetwork_redundant_check(std::string &log, std::vector<std::string> &srcs)
+{
+ bool ret = false;
+ std::regex
bnetwork_regex("#[[:space:]]*include[[:space:]]*\"bnetwork.h\".*");
+ std::regex inc_regex("#[[:space:]]*include.*");
+ const char *redundant_filters[] {
+ ".*<winsock2.h>.*",
+ ".*<netinet/in.h>.*",
+ ".*<netinet/tcp.h>.*",
+ ".*<arpa/inet.h>.*",
+ NULL
+ };
+
+ std::map<std::string, std::regex> filters;
+ int cnt = 0;
+ const char *rf = redundant_filters[cnt];
+ while (rf) {
+ filters[std::string(rf)] = std::regex(rf);
+ cnt++;
+ rf = redundant_filters[cnt];
+ }
+
+
+ for (size_t i = 0; i < srcs.size(); i++) {
+ std::string sline;
+
+ std::map<std::string, std::set<int>> match_line_nums;
+
+ std::ifstream fs;
+ fs.open(srcs[i]);
+ if (!fs.is_open()) {
+ std::cerr << "Unable to open " << srcs[i] << " for reading,
skipping\n";
+ continue;
+ }
+
+ int lcnt = 0;
+ bool have_bnetwork = false;
+ while (std::getline(fs, sline) && lcnt < MAX_LINES_CHECK) {
+ lcnt++;
+ if (std::regex_match(sline, bnetwork_regex)) {
+ have_bnetwork = true;
+ continue;
+ }
+
+ std::map<std::string, std::regex>::iterator f_it;
+ for (f_it = filters.begin(); f_it != filters.end(); f_it++) {
+ if (std::regex_match(sline, f_it->second)) {
+ match_line_nums[f_it->first].insert(lcnt);
+ continue;
+ }
+ }
+ }
+
+ if (have_bnetwork) {
+ std::map<std::string, std::set<int>>::iterator m_it;
+ for (m_it = match_line_nums.begin(); m_it != match_line_nums.end();
m_it++) {
+ if (m_it->second.size()) {
+ std::set<int>::iterator l_it;
+ ret = true;
+ for (l_it = m_it->second.begin(); l_it !=
m_it->second.end(); l_it++) {
+ std::string lstr = srcs[i] + std::string(" has
bnetwork.h, but also matches regex ") + m_it->first + std::string(" on line ")
+ std::to_string(lcnt) + std::string("\n");
+ log.append(lstr);
+ }
+ }
+ }
+ }
+ }
+
+ return ret;
+}
+
+
+
+bool
+common_include_first(std::string &log, std::vector<std::string> &srcs)
+{
+ bool ret = false;
+ std::regex inc_regex("#[[:space:]]*include.*");
+ std::regex common_regex("#[[:space:]]*include[[:space:]]*\"common.h\".*");
+ const char *exempt_filters[] {
+ ".*/bio.h",
+ ".*/bnetwork.h",
+ ".*/config_win.h",
+ ".*/csg_parser.c",
+ ".*/csg_scanner.h",
+ ".*/obj_grammar.c",
+ ".*/obj_grammar.cpp",
+ ".*/obj_libgcv_grammar.cpp",
+ ".*/obj_obj-g_grammar.cpp",
+ ".*/obj_parser.h",
+ ".*/obj_rules.cpp",
+ ".*/obj_rules.l",
+ ".*/obj_scanner.h",
+ ".*/obj_util.h",
+ ".*/optionparser.h",
+ ".*/pinttypes.h",
+ ".*/points_scan.c",
+ ".*/pstdint.h",
+ ".*/schema.h",
+ ".*/script.c",
+ ".*/ttcp.c",
+ ".*/uce-dirent.h",
+ NULL
+ };
+
+ std::vector<std::regex> filters;
+ int cnt = 0;
+ const char *rf = exempt_filters[cnt];
+ while (rf) {
+ filters.push_back(std::regex(rf));
+ cnt++;
+ rf = exempt_filters[cnt];
+ }
+
+ for (size_t i = 0; i < srcs.size(); i++) {
+ bool skip = false;
+ for (size_t j = 0; j < filters.size(); j++) {
+ if (std::regex_match(srcs[i], filters[j])) {
+ skip = true;
+ break;
+ }
+ }
+ if (skip) {
+ continue;
+ }
+
+ std::ifstream fs;
+ fs.open(srcs[i]);
+ if (!fs.is_open()) {
+ std::cerr << "Unable to open " << srcs[i] << " for reading,
skipping\n";
+ continue;
+ }
+
+ int lcnt = 0;
+ int first_inc_line = -1;
+ //bool have_common = false;
+ bool have_inc = false;
+ std::string sline;
+ while (std::getline(fs, sline) && lcnt < MAX_LINES_CHECK) {
+ lcnt++;
+ if (std::regex_match(sline, common_regex)) {
+ //have_common = true;
+ if (have_inc) {
+ std::string lstr = srcs[i] + std::string(" has common.h
included on line ") + std::to_string(lcnt) + std::string(" but a prior #include
statement was found at line ") + std::to_string(first_inc_line) +
std::string("\n");
+ log.append(lstr);
+ ret = true;
+ }
+ break;
+ }
+ if (!have_inc && std::regex_match(sline, inc_regex)) {
+ have_inc = true;
+ first_inc_line = lcnt;
+ }
+ }
+#if 0
+ // We don't include common.h in all source files, so we don't fail if
it's not present
+ if (!have_common) {
+ std::string lstr = srcs[i] + std::string(" does not include the
common.h header\n");
+ log.append(lstr);
+ ret = true;
+ }
+#endif
+ }
+
+
+ return ret;
+}
+
+bool
+api_usage(std::string &log, std::vector<std::string> &srcs)
+{
+ bool ret = false;
+ std::map<std::string, std::vector<std::regex>> exemptions;
+
exemptions[std::string(".*[^a-zA-Z0-9_:]abort[(].*")].push_back(std::regex(".*/bomb[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]dirname[(].*")].push_back(std::regex(".*/tests/dirname[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]remove[(].*")].push_back(std::regex(".*/file[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strcasecmp[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strcmp[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strdup[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strlcat[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncasecmp[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncat[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncmp[(]*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncpy[(].*")].push_back(std::regex(".*/rt/db4[.]h$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncpy[(].*")].push_back(std::regex(".*/str[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncpy[(].*")].push_back(std::regex(".*/vls[.]c$"));
+
exemptions[std::string(".*[^a-zA-Z0-9_:]strncpy[(].*")].push_back(std::regex(".*/wfobj/obj_util[.]cpp$"));
+
+ const char *file_exemptions[] {
+ ".*/CONFIG_CONTROL_DESIGN.*",
+ ".*/bu/log[.]h$",
+ ".*/bu/path[.]h$",
+ ".*/bu/str[.]h$",
+ ".*/cursor[.]c$",
+ ".*/ttcp[.]c$",
+ NULL
+ };
+
+ const char *funcs[] {
+ ".*[^a-zA-Z0-9_:]abort[(].*",
+ ".*[^a-zA-Z0-9_:]dirname[(].*",
+ ".*[^a-zA-Z0-9_:]fgets[(].*",
+ ".*[^a-zA-Z0-9_:]getopt[(].*",
+ ".*[^a-zA-Z0-9_:]qsort[(].*",
+ ".*[^a-zA-Z0-9_:]remove[(].*",
+ ".*[^a-zA-Z0-9_:]rmdir[(].*",
+ ".*[^a-zA-Z0-9_:]strcasecmp[(].*",
+ ".*[^a-zA-Z0-9_:]strcat[(].*",
+ ".*[^a-zA-Z0-9_:]strcmp[(].*",
+ ".*[^a-zA-Z0-9_:]strcpy[(].*",
+ ".*[^a-zA-Z0-9_:]strdup[(].*",
+ ".*[^a-zA-Z0-9_:]stricmp[(].*",
+ ".*[^a-zA-Z0-9_:]strlcat[(].*",
+ ".*[^a-zA-Z0-9_:]strlcpy[(].*",
+ ".*[^a-zA-Z0-9_:]strncasecmp[(].*",
+ ".*[^a-zA-Z0-9_:]strncat[(].*",
+ ".*[^a-zA-Z0-9_:]strncmp[(].*",
+ ".*[^a-zA-Z0-9_:]strncpy[(].*",
+ ".*[^a-zA-Z0-9_:]unlink[(].*",
+ NULL
+ };
+
+ std::vector<std::regex> file_filters;
+ int cnt = 0;
+ const char *rf = file_exemptions[cnt];
+ while (rf) {
+ file_filters.push_back(std::regex(rf));
+ cnt++;
+ rf = file_exemptions[cnt];
+ }
+
+ std::map<std::string, std::regex> func_filters;
+ cnt = 0;
+ rf = funcs[cnt];
+ while (rf) {
+ func_filters[std::string(rf)] = std::regex(rf);
+ cnt++;
+ rf = funcs[cnt];
+ }
+
+
+ for (size_t i = 0; i < srcs.size(); i++) {
+ bool skip = false;
+ for (size_t j = 0; j < file_filters.size(); j++) {
+ if (std::regex_match(srcs[i], file_filters[j])) {
+ skip = true;
+ break;
+ }
+ }
+ if (skip) {
+ continue;
+ }
+
+ std::ifstream fs;
+ fs.open(srcs[i]);
+ if (!fs.is_open()) {
+ std::cerr << "Unable to open " << srcs[i] << " for reading,
skipping\n";
+ continue;
+ }
+
+ std::map<std::string, std::set<int>> instances;
+
+ int lcnt = 0;
+ std::string sline;
+ while (std::getline(fs, sline)) {
+ lcnt++;
+ std::map<std::string, std::regex>::iterator ff_it;
+ for (ff_it = func_filters.begin(); ff_it != func_filters.end();
ff_it++) {
+ if (std::regex_match(sline, ff_it->second)) {
+ // If we have a it, make sure it's not an exemption
+ std::cout << "check " << sline << "\n";
+ bool exempt = false;
+ if (exemptions.find(ff_it->first) != exemptions.end()) {
+ std::vector<std::regex>::iterator e_it;
+ for (e_it = exemptions[ff_it->first].begin(); e_it !=
exemptions[ff_it->first].end(); e_it++) {
+ if (std::regex_match(srcs[i], *e_it)) {
+ exempt = true;
+ break;
+ }
+ }
+ }
+ if (!exempt) {
+ instances[ff_it->first].insert(lcnt);
+ ret = true;
+ }
+ }
+ }
+ }
+
+ std::map<std::string, std::set<int>>::iterator i_it;
+
+ for (i_it = instances.begin(); i_it != instances.end(); i_it++) {
+ std::set<int>::iterator num_it;
+ for (num_it = i_it->second.begin(); num_it != i_it->second.end();
num_it++) {
+ std::string lstr = srcs[i] + std::string(" matches ") + i_it->first
+ std::string(" on line ") + std::to_string(*num_it) + std::string("\n");
+ log.append(lstr);
+ }
+ }
+ }
+
+ return ret;
+}
+
+
+int
+main(int argc, const char *argv[])
+{
+ if (argc != 2) {
+ std::cerr << "Usage: repocheck file_list.txt\n";
+ return -1;
+ }
+
+ std::string sfile;
+ std::ifstream src_file_stream;
+ src_file_stream.open(argv[1]);
+ if (!src_file_stream.is_open()) {
+ std::cerr << "Unable to open file list file " << argv[1] << "\n";
+ return -1;
+ }
+
+
+ // Build a set of filters that will cull out files which would otherwise
+ // be matches for items of interest
+ const char *reject_filters[] {
+ ".*/bullet/.*",
+ ".*/doc/.*",
+ ".*/shapelib/.*",
+ ".*[.]log",
+ ".*[.]svn.*",
+ ".*misc/CMake/Find.*",
+ ".*misc/repoconv.*",
+ ".*misc/tools.*",
+ ".*misc/debian.*",
+ ".*pkg.h",
+ ".*src/libpkg.*",
+ ".*src/other.*",
+ ".*~",
+ NULL
+ };
+
+ std::vector<std::regex> filters;
+ int cnt = 0;
+ const char *rf = reject_filters[cnt];
+ while (rf) {
+ filters.push_back(std::regex(rf));
+ cnt++;
+ rf = reject_filters[cnt];
+ }
+
+
+ // Apply filters and build up the file sets we want to introspect.
+ std::regex codefile_regex(".*[.](c|cpp|cxx|cc|h|hpp|hxx|y|yy|l)([.]in)?$");
+ std::regex buildfile_regex(".*([.]cmake([.]in)?|CMakeLists.txt)$");
+ std::regex hdrfile_regex(".*/include/.*");
+ std::vector<std::string> src_files;
+ std::vector<std::string> inc_files;
+ std::vector<std::string> build_files;
+
+ while (std::getline(src_file_stream, sfile)) {
+ bool reject = false;
+ for (size_t i = 0; i < filters.size(); i++) {
+ if (std::regex_match(sfile, filters[i])) {
+ reject = true;
+ break;
+ }
+ }
+ if (reject) {
+ continue;
+ }
+
+ if (std::regex_match(sfile, codefile_regex)) {
+ if (std::regex_match(sfile, hdrfile_regex)) {
+ inc_files.push_back(sfile);
+ } else {
+ src_files.push_back(sfile);
+ }
+ continue;
+ }
+ if (std::regex_match(sfile, buildfile_regex)) {
+ build_files.push_back(sfile);
+ continue;
+ }
+ }
+
+ int ret = 0;
+
+ std::string log;
+ if (priv_includes_public_hdrs(log, inc_files)) {
+ ret = -1;
+ }
+
+ if (bio_redundant_check(log, src_files)) {
+ ret = -1;
+ }
+
+ if (bnetwork_redundant_check(log, src_files)) {
+ ret = -1;
+ }
+
+ if (common_include_first(log, src_files)) {
+ ret = -1;
+ }
+
+ if (api_usage(log, src_files)) {
+ ret = -1;
+ }
+
+ if (ret) {
+ std::cerr << log << "\n";
+ }
+
+ return ret;
+}
+
+// Local Variables:
+// tab-width: 8
+// mode: C++
+// c-basic-offset: 4
+// indent-tabs-mode: t
+// c-file-style: "stroustrup"
+// End:
+// ex: shiftwidth=4 tabstop=8
Property changes on: brlcad/trunk/regress/repository/repocheck.cpp
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
