Revision: 76026
http://sourceforge.net/p/brlcad/code/76026
Author: starseeker
Date: 2020-06-04 18:15:02 +0000 (Thu, 04 Jun 2020)
Log Message:
-----------
As far as I can tell, no one is manipulating vectorThreshold. The only
motivation to would be to adjust the update/refresh rate of the dm, and even if
that might be useful under some hypothetical circumstance this was never
documented at all.
Modified Paths:
--------------
brlcad/branches/dm-fb-merge/src/libdm/X/dm-X.c
brlcad/branches/dm-fb-merge/src/libdm/dm-generic.c
brlcad/branches/dm-fb-merge/src/libdm/include/private.h
brlcad/branches/dm-fb-merge/src/libdm/tk/dm-tk.c
brlcad/branches/dm-fb-merge/src/libtclcad/dm_tcl.c
Modified: brlcad/branches/dm-fb-merge/src/libdm/X/dm-X.c
===================================================================
--- brlcad/branches/dm-fb-merge/src/libdm/X/dm-X.c 2020-06-04 17:50:20 UTC
(rev 76025)
+++ brlcad/branches/dm-fb-merge/src/libdm/X/dm-X.c 2020-06-04 18:15:02 UTC
(rev 76026)
@@ -71,6 +71,9 @@
#define DM_X_DEFAULT_POINT_SIZE 1.0
+/* Vector count at which a Tcl event processing step is triggered */
+#define vectorThreshold 100000
+
extern void X_allocate_color_cube(Display *, Colormap, long unsigned int *,
int, int, int);
extern unsigned long X_get_pixel(unsigned char, unsigned char, unsigned char,
long unsigned int *, int);
@@ -856,8 +859,6 @@
HIDDEN int
X_drawVList(struct dm *dmp, struct bn_vlist *vp)
{
- extern int vectorThreshold; /* defined in libdm/dm-generic.c */
-
static vect_t spnt, lpnt, pnt;
struct bn_vlist *tvp;
XSegment segbuf[1024]; /* XDrawSegments list */
Modified: brlcad/branches/dm-fb-merge/src/libdm/dm-generic.c
===================================================================
--- brlcad/branches/dm-fb-merge/src/libdm/dm-generic.c 2020-06-04 17:50:20 UTC
(rev 76025)
+++ brlcad/branches/dm-fb-merge/src/libdm/dm-generic.c 2020-06-04 18:15:02 UTC
(rev 76026)
@@ -33,13 +33,6 @@
#include "./include/private.h"
#include "./null/dm-Null.h"
-/*
- * TODO - figure out if anything in Tcl land is actually using the libtclcad
- * DM_Init LinkVar linkage to manipulate this, or if any user features are
- * actually depending on the vectorThreshold - this needs to go.
- */
-int vectorThreshold = 100000;
-
void *
dm_interp(struct dm *dmp)
{
Modified: brlcad/branches/dm-fb-merge/src/libdm/include/private.h
===================================================================
--- brlcad/branches/dm-fb-merge/src/libdm/include/private.h 2020-06-04
17:50:20 UTC (rev 76025)
+++ brlcad/branches/dm-fb-merge/src/libdm/include/private.h 2020-06-04
18:15:02 UTC (rev 76026)
@@ -228,9 +228,6 @@
DM_EXPORT extern int fb_sim_writerect(struct fb *ifp, int xmin, int ymin, int
_width, int _height, const unsigned char *pp);
DM_EXPORT extern int fb_sim_bwwriterect(struct fb *ifp, int xmin, int ymin,
int _width, int _height, const unsigned char *pp);
-/* Global, defined in dm-generic.c */
-DM_EXPORT extern int vectorThreshold;
-
__END_DECLS
/************************************************/
Modified: brlcad/branches/dm-fb-merge/src/libdm/tk/dm-tk.c
===================================================================
--- brlcad/branches/dm-fb-merge/src/libdm/tk/dm-tk.c 2020-06-04 17:50:20 UTC
(rev 76025)
+++ brlcad/branches/dm-fb-merge/src/libdm/tk/dm-tk.c 2020-06-04 18:15:02 UTC
(rev 76026)
@@ -64,11 +64,11 @@
#define PLOTBOUND 1000.0 /* Max magnification in Rot matrix */
+#define vectorThreshold 100000
+
static fastf_t min_short = (fastf_t)SHRT_MIN;
static fastf_t max_short = (fastf_t)SHRT_MAX;
-extern int vectorThreshold; /* defined in libdm/dm-generic.c */
-
static int tk_close(struct dm *dmp);
static int tk_configureWin_guts(struct dm *dmp, int force);
Modified: brlcad/branches/dm-fb-merge/src/libtclcad/dm_tcl.c
===================================================================
--- brlcad/branches/dm-fb-merge/src/libtclcad/dm_tcl.c 2020-06-04 17:50:20 UTC
(rev 76025)
+++ brlcad/branches/dm-fb-merge/src/libtclcad/dm_tcl.c 2020-06-04 18:15:02 UTC
(rev 76026)
@@ -177,16 +177,9 @@
{(const char *)NULL, BU_CMD_NULL}
};
- struct bu_vls vls = BU_VLS_INIT_ZERO;
-
/* register commands */
register_cmds(interp, cmdtab);
- bu_vls_strcpy(&vls, "vectorThreshold");
- Tcl_LinkVar(interp, bu_vls_addr(&vls), (char *)&vectorThreshold,
- TCL_LINK_INT);
- bu_vls_free(&vls);
-
/* initialize display manager object code */
Dmo_Init(interp);
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
