Revision: 76043
http://sourceforge.net/p/brlcad/code/76043
Author: starseeker
Date: 2020-06-06 17:10:58 +0000 (Sat, 06 Jun 2020)
Log Message:
-----------
BRLCADBUILD and HAVE_CONFIG_H target defines need to be PRIVATE, or they will
propagate to targets linking libraries automatically. We should replace our
custom management of define propagation with this feature, but in the specific
case of these definitions they should not propagate - they are specific to each
compile.
Modified Paths:
--------------
brlcad/trunk/misc/CMake/BRLCAD_Targets.cmake
Modified: brlcad/trunk/misc/CMake/BRLCAD_Targets.cmake
===================================================================
--- brlcad/trunk/misc/CMake/BRLCAD_Targets.cmake 2020-06-06 15:43:48 UTC
(rev 76042)
+++ brlcad/trunk/misc/CMake/BRLCAD_Targets.cmake 2020-06-06 17:10:58 UTC
(rev 76043)
@@ -365,7 +365,7 @@
endif(E_GUI)
# Set the standard build definitions for all BRL-CAD targets
- target_compile_definitions(${execname} PUBLIC BRLCADBUILD HAVE_CONFIG_H)
+ target_compile_definitions(${execname} PRIVATE BRLCADBUILD HAVE_CONFIG_H)
# Let CMAKEFILES know what's going on
CMAKEFILES(${srcslist})
@@ -469,7 +469,7 @@
set_target_properties(${libname}-obj PROPERTIES FOLDER "BRL-CAD OBJECT
Libraries${SUBFOLDER}")
# Set the standard build definitions for all BRL-CAD targets
- target_compile_definitions(${libname}-obj PUBLIC BRLCADBUILD HAVE_CONFIG_H)
+ target_compile_definitions(${libname}-obj PRIVATE BRLCADBUILD
HAVE_CONFIG_H)
if(HIDE_INTERNAL_SYMBOLS)
string(REPLACE "lib" "" LOWERCORE "${libname}")
@@ -493,7 +493,7 @@
add_library(${libname} SHARED ${lsrcslist} ${L_SHARED_SRCS})
# Set the standard build definitions for all BRL-CAD targets
- target_compile_definitions(${libname} PUBLIC BRLCADBUILD HAVE_CONFIG_H)
+ target_compile_definitions(${libname} PRIVATE BRLCADBUILD HAVE_CONFIG_H)
if(HIDE_INTERNAL_SYMBOLS)
string(REPLACE "lib" "" LOWERCORE "${libname}")
@@ -513,7 +513,7 @@
add_library(${libstatic} STATIC ${lsrcslist} ${L_STATIC_SRCS})
# Set the standard build definitions for all BRL-CAD targets
- target_compile_definitions(${libstatic} PUBLIC BRLCADBUILD HAVE_CONFIG_H)
+ target_compile_definitions(${libstatic} PRIVATE BRLCADBUILD HAVE_CONFIG_H)
if(NOT MSVC)
set_target_properties(${libstatic} PROPERTIES OUTPUT_NAME "${libname}")
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
