Revision: 76291
          http://sourceforge.net/p/brlcad/code/76291
Author:   starseeker
Date:     2020-07-09 21:34:06 +0000 (Thu, 09 Jul 2020)
Log Message:
-----------
Urk - v4 .g writing is going to be a job to retrofit for modern (v5) inputs.  
Maybe reject any input except a v4 db file?  Or just dispense with the ability 
to write out this format, since db_upgrade is supposed to handle v4 upgrading.

Modified Paths:
--------------
    brlcad/trunk/src/libgcv/plugins/asc/asc_v4.cpp

Modified: brlcad/trunk/src/libgcv/plugins/asc/asc_v4.cpp
===================================================================
--- brlcad/trunk/src/libgcv/plugins/asc/asc_v4.cpp      2020-07-09 21:15:14 UTC 
(rev 76290)
+++ brlcad/trunk/src/libgcv/plugins/asc/asc_v4.cpp      2020-07-09 21:34:06 UTC 
(rev 76291)
@@ -1602,6 +1602,24 @@
     return 1;
 }
 
+
+/**************************************************************/
+
+// TODO - if I'm not mistaken, the v4 writing code requires
+// a db4 .g file?  It seems to be reading the file contents
+// and processing them, rather than loading the .g normally
+// and writing out data from in-memory structures.
+//
+// We definitely still need to read v4 - most of BRL-CAD's
+// default examples are in that format.  Do we still need
+// to write it?  If so, this pretty much needs a complete
+// rewrite, unless we do some weird contortions to only
+// allow callers to pair this with a db4 input (which really
+// isn't in the spirit of gcv...) - CY
+
+/**************************************************************/
+
+
 static int     combdump(void);
 static void    idendump(void), polyhead_asc(void), polydata_asc(void);
 static void    soldump(void), extrdump(void), sketchdump(void);
@@ -2488,6 +2506,9 @@
     }
 }
 
+/*******************************************************************/
+/*                     Main asc V4 write entry point                */
+/*******************************************************************/
 int
 asc_write_v4(
            struct gcv_context *UNUSED(c),

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to