Revision: 76626
          http://sourceforge.net/p/brlcad/code/76626
Author:   brlcad
Date:     2020-08-01 04:32:40 +0000 (Sat, 01 Aug 2020)
Log Message:
-----------
felt wrong because it definitely is wrong.

ged_init() is responsible (as are all init/INIT functions/macros) for
initializing ALL members of the ged struct.  accessing the struct
directly, outside of libged functions, is in the wrong direction too.
fields should be opaque caller.  this is tight architecture coupling.

Modified Paths:
--------------
    brlcad/branches/bioh/src/libged/ged.c

Modified: brlcad/branches/bioh/src/libged/ged.c
===================================================================
--- brlcad/branches/bioh/src/libged/ged.c       2020-08-01 04:24:18 UTC (rev 
76625)
+++ brlcad/branches/bioh/src/libged/ged.c       2020-08-01 04:32:40 UTC (rev 
76626)
@@ -271,14 +271,9 @@
     gedp->ged_create_vlist_solid_callback = NULL;
     gedp->ged_create_vlist_callback = NULL;
     gedp->ged_free_vlist_callback = NULL;
-    /* NOTE - MGED is already setting these
-     * before calling ged_init.  Doesn't
-     * feel right... */
-#if 0
     gedp->ged_create_io_handler = NULL;
     gedp->ged_delete_io_handler = NULL;
     gedp->ged_io_data = NULL;
-#endif
 
     /* Out of the gate we don't have display managers or views */
     gedp->ged_gvp = NULL;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to