Revision: 76631
http://sourceforge.net/p/brlcad/code/76631
Author: brlcad
Date: 2020-08-01 07:06:58 +0000 (Sat, 01 Aug 2020)
Log Message:
-----------
leave a note regarding the need to move towards fewer and hidden ged struct
fields.
Modified Paths:
--------------
brlcad/branches/bioh/include/ged/defines.h
Modified: brlcad/branches/bioh/include/ged/defines.h
===================================================================
--- brlcad/branches/bioh/include/ged/defines.h 2020-08-01 06:59:18 UTC (rev
76630)
+++ brlcad/branches/bioh/include/ged/defines.h 2020-08-01 07:06:58 UTC (rev
76631)
@@ -222,12 +222,19 @@
char *ged_output_script; /**< @brief
script for use by the outputHandler */
+ /* FIXME -- this ugly hack needs to die. the result string should
+ * be stored before the call.
+ */
+ int ged_internal_call;
- /* FIXME -- this ugly hack needs to die. the result string should be
stored before the call. */
- int ged_internal_call;
+ /* TODO: hide all callback related symbols, callback typedefs
+ * (above), and eventually most if not all of the remaining fields
+ * into an _impl structure so callers are not tightly coupled to
+ * the ged structure. access via public functions that have been
+ * given design consideration.
+ */
-
/* FOR LIBGED INTERNAL USE */
struct ged_cmd *cmds;
int (*add)(struct ged *gedp, const struct ged_cmd *cmd);
@@ -241,6 +248,7 @@
/* Callbacks */
+
struct ged_callback_state *ged_cbs;
void (*ged_refresh_handler)(void *); /**< @brief
function for handling refresh requests */
void *ged_refresh_clientdata; /**< @brief
client data passed to refresh handler */
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
