Revision: 77399
http://sourceforge.net/p/brlcad/code/77399
Author: starseeker
Date: 2020-10-10 03:01:43 +0000 (Sat, 10 Oct 2020)
Log Message:
-----------
Very important flag we weren't setting to get working linking, apparently. Per
https://stackoverflow.com/a/49390802 set IMPORTED_NO_SONAME to true. Using the
targets now seems to produce correct links, at least in the initial test.
Modified Paths:
--------------
brlcad/branches/thirdparty_rework/src/superbuild/CMake/ExternalProject_Target.cmake
Modified:
brlcad/branches/thirdparty_rework/src/superbuild/CMake/ExternalProject_Target.cmake
===================================================================
---
brlcad/branches/thirdparty_rework/src/superbuild/CMake/ExternalProject_Target.cmake
2020-10-10 02:45:34 UTC (rev 77398)
+++
brlcad/branches/thirdparty_rework/src/superbuild/CMake/ExternalProject_Target.cmake
2020-10-10 03:01:43 UTC (rev 77399)
@@ -148,8 +148,13 @@
set(IMPORT_PREFIX "${IMPORT_PREFIX}/${IN_IMPORT_PREFIX}")
endif(IN_IMPORT_PREFIX)
+ # Note: per https://stackoverflow.com/a/49390802 need to set
+ # IMPORTED_NO_SONAME to get working linking for what we're trying to do
+ # here. Without that property set, build dir copies of libraries will use
+ # an incorrect relative link and fail to find the library.
set_property(TARGET ${etarg} APPEND PROPERTY IMPORTED_CONFIGURATIONS
NOCONFIG)
set_target_properties(${etarg} PROPERTIES
+ IMPORTED_NO_SONAME TRUE
IMPORTED_LOCATION_NOCONFIG "${IMPORT_PREFIX}/${IN_LINK_TARGET}"
IMPORTED_SONAME_NOCONFIG "${IN_LINK_TARGET}"
)
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
