Revision: 77965
http://sourceforge.net/p/brlcad/code/77965
Author: starseeker
Date: 2020-12-11 19:14:05 +0000 (Fri, 11 Dec 2020)
Log Message:
-----------
Need to figure out how to handle the c4251 situation 'properly' since we've now
hit a case (Ninja Windows build) where the problematic behavior is realized.
Modified Paths:
--------------
brlcad/branches/extbuild/src/other/ext/stepcode/src/clstepcore/entityDescriptor.h
Modified:
brlcad/branches/extbuild/src/other/ext/stepcode/src/clstepcore/entityDescriptor.h
===================================================================
---
brlcad/branches/extbuild/src/other/ext/stepcode/src/clstepcore/entityDescriptor.h
2020-12-11 18:46:18 UTC (rev 77964)
+++
brlcad/branches/extbuild/src/other/ext/stepcode/src/clstepcore/entityDescriptor.h
2020-12-11 19:14:05 UTC (rev 77965)
@@ -34,6 +34,11 @@
EntityDescriptorList _supertypes; // OPTIONAL
AttrDescriptorList _explicitAttr; // OPTIONAL
Inverse_attributeList _inverseAttr; // OPTIONAL
+
+// TODO - We need to address this issue properly:
+//
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
+// Ninja build on Windows is resulting in non-functional step tools, and
WinDBG leads back to this
+// string (probably among others) being in a corrupted state.
#ifdef _MSC_VER
#pragma warning( push )
#pragma warning( disable: 4251 )
@@ -140,7 +145,7 @@
{
_subtypes.AddNode(ed);
}
- void AddSupertype_Stmt(const std::string s)
+ void AddSupertype_Stmt(const std::string &s)
{
_supertype_stmt = s;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
