Revision: 78079
          http://sourceforge.net/p/brlcad/code/78079
Author:   starseeker
Date:     2021-01-14 18:48:40 +0000 (Thu, 14 Jan 2021)
Log Message:
-----------
Make a note - we'll have to do each specified push fully before processing the 
next, if multiple comb inputs are specified to the push command.

Modified Paths:
--------------
    brlcad/trunk/src/libged/npush/npush.cpp

Modified: brlcad/trunk/src/libged/npush/npush.cpp
===================================================================
--- brlcad/trunk/src/libged/npush/npush.cpp     2021-01-14 18:43:05 UTC (rev 
78078)
+++ brlcad/trunk/src/libged/npush/npush.cpp     2021-01-14 18:48:40 UTC (rev 
78079)
@@ -487,6 +487,11 @@
     for (int i = 0; i < argc; i++) {
        s.target_objs.insert(std::string(argv[i]));
     }
+
+    // TODO - either need to validate that no target_obj is underneath another 
target obj,
+    // or fully process the first target obj before moving on to the second.  
Otherwise
+    // multiple push operations may collide.
+
     std::set<std::string>::iterator s_it;
     for (s_it = s.target_objs.begin(); s_it != s.target_objs.end(); s_it++) {
        struct directory *dp = db_lookup(dbip, s_it->c_str(), LOOKUP_NOISY);
@@ -501,7 +506,6 @@
        return GED_ERROR;
     }
 
-
     /* Because pushes have potentially global consequences, we must
      * also characterize all unique object instances in the database.  That
      * information will be needed to know if any given matrix push is self

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits

Reply via email to