On Apr 21, 2010, at 10:54 AM, Tom Browder wrote:

> Good work!  It works without my adding a define and with the default
> g++-4.5.0 configuration.

Excellent!

> For your info, the attached file has that output.  The  relevant
> macros which triggered inclusion of stdint.h in common.h are:
>
>   __STDC__
>   __SIZE_TYPE__

Interesting, g++ shouldn't set __STDC__ unless you pass -std flags or  
used gcc, or maybe things changed for 4.5.

> By the way, if I were to write notes for those using gcc/g++ (maybe
> add in the INSTALL file?) I would add something like the following:

Hm, not a bad idea but how about further simplification?  Your  
comment raises a point that we've had to explain numerous times,  
namely that we don't care about src/other.  So perhaps we should just  
quiet all compiler warnings when we're traversing through there..  If  
there are warnings in our code, we should fix them.

> P.S.  I see lots of warnings from "other" sources besides openNURBS.
> Let me know if there are any you would like to have compiler warnings
> looked into--I'll take that on when I can (I know you want to leave
> openNURBS alone).

As we don't really want to get into the business of working on 3rd  
party code any more than we have to (as we have more than enough to  
do in our own code, after all), those have been intentionally  
ignored.  Plus, any changes we would make get wiped out on the next  
update and have to be reapplied until upstream is fixed.  That's why  
src/other blather's warnings extensively and our code is being  
hardened to quell absolutely everything.

Cheers!
Sean


------------------------------------------------------------------------------
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to