On May 12, 2012, at 3:37 PM, Cristina Precup wrote: > - one which includes unit tests for the src/libbu/booleanize.c file. > You can find it here: > https://sourceforge.net/tracker/?func=detail&aid=3519874&group_id=105292&atid=640804
It's great to see such a detailed unit test, but the style and formatting should be consistent with the rest of the project as described in our HACKING guideline's CODING STYLE & STANDARDS section. Specifically, open braces on the same line as if/else statements, space after "if" keywords, else on same line as closing brace, and including braces for multiline if/else blocks (even if technically a single line) were a few things I noticed at a glance. You'll have an opportunity to fix it later, so don't worry about updating the patch (especially since it's been applied). > - the second one is meant to separate out LIBNMG from LIBRT. You can > find it here: > https://sourceforge.net/tracker/?func=detail&aid=3526143&group_id=105292&atid=640804 Haven't reviewed it yet, but that's just awesome. Really. > 2. I have written a previous email to this mailing list where I've > introduced myself in order to get in touch with my mentor. His name is > Nick (as I've seen on the google-melange page). Could you tell me if > he has a IRC nickname or maybe an email? I can't seem to find him on > the mentors list on brlcad.org. He's usually n_reed on IRC. Generally quiet unless you ask him a specific question. :) Cheers! Sean ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
