On May 21, 2012, at 02:23 PM, Suryajith Chillara <[email protected]> wrote:

Attached is my patch to bench/pixcmp.c which adds the option of adding
the parameter so that one could check the number of pixels which are
"off by a certain value". The default value is still 1. I've tested for
a few cases and they were fine but I want to be absolutely sure before I
can commit it to the trunk.

Suryajith,

Patches files should be submitted to the patches tracker, not to the mailing list.  It's easier to track updated versions and isolate commentary from other ongoing development discussions.  You will not be able to commit until you've demonstrated (via patches) that you're following our coding practices described in the HACKING file.

Could you please check if that is what I was expected to rewrite?

Did you test to make sure the benchmark tool still completes successfully with the pixcmp modification?  If not, you should.

Thanks,
Sean


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to