On Thu, May 31, 2012 at 5:52 AM, Tom Browder <tom.brow...@gmail.com> wrote: > On Wed, May 30, 2012 at 9:28 PM, Clifford Yapp <cliffy...@gmail.com> wrote: >> Tom, can you try running the iges regression target (make >> regress-iges) and see if you are getting failures? If I'm >> interpreting my testing correctly, it looks like the new vls work may >> have introduced the regression.
Cliff, the error is two-fold: 1. vls_vprintf did detect an error in output formatting but the error handling was not correct: I fixed that, and I also added a default output to guess a valid input to sprintf. 2. the real problem is in iges.c in these lines: 744: bu_vls_printf(&str, ",, %zH%s", strlen(db_name), db_name); 749: bu_vls_printf(&str, ", %zH%s", strlen(output_file), output_file); 751: bu_vls_printf(&str, ", %zH%s, %zH%s, 32, 38, 6, 308, 15, %zH%s, 1.0, 2, 2HMM,, 1.0" , 1979: bu_vls_printf(&str, "406, 1, %zH%s;", strlen(name), name); Those lines have been there a long time and the "%zH" produces "%H" in the output (also with sprintf). Consider line 747: bu_vls_printf(&str, ", 7Hstd_out"); Based on line 747 (and others like it), and looking at the variables trying to be printed, I think those lines should be: 744: bu_vls_printf(&str, ",, %zdH%s", strlen(db_name), db_name); 749: bu_vls_printf(&str, ", %zdH%s", strlen(output_file), output_file); 751: bu_vls_printf(&str, ", %zdH%s, %zdH%s, 32, 38, 6, 308, 15, %zdH%s, 1.0, 2, 2HMM,, 1.0" , 1979: bu_vls_printf(&str, "406, 1, %zdH%s;", strlen(name), name); (So the output looks like it uses the old Hollerith-type string format.) I made the corrections and the test now works fine. Good catch--regression works! Best regards, -Tom P.S. I learned my lesson: Major changes in anything require the complete regression suite (I already knew that, I just go cocky). > > Will do. > > -Tom ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
