On Jul 11, 2012, at 3:53 AM, plussai wrote:
> Hi!
> My patch for brep_debug.cpp is baesd on the revision 50509,but it is not
> the latest revision.Is it OK? or it need to make my patch adjust to the
> latest revision.
Anything that makes it easier to review your patch helps get them reviewed and
applied more quickly. At a minimum, your patch submission should say what
source revision you're based off of, but the latest revision is better for
obvious reasons.
If you need to change your patch, it's always a good idea to use a clean
up-to-date checkout and update it first. Apply your patch yourself ("patch -p0
< my_patch_file.diff" is what we usually like to use), see if anything fails,
make corrections to merge any rejections, then make your changes for updating
the patch. If you get rejections, so will others. Nobody is more appropriate
for fixing them than you! :)
If you don't update it, who will? We will, and that just means it'll take that
much more effort to apply causing your patch to just sit there even longer...
Cheers!
Sean
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
