Is it possible to commit the mged hook to voxelize? Two things from a short code review: - rtip should be freed after usage. - prep should be called in voxelize().
Daniel 2012/7/13 Anurag Murty <anuragmu...@gmail.com>: > Daniel, > > I do have to change the location of the call-back functions and will do so > now. I will move printToFile and printToScreen to g-voxel, voxels.c(with its > new name) etc. > > I did commit voxelize.c yesterday and that is giving me segmentation fault. > I think the problem might be with the way I have defined functions in > analyze.h. But I will wait for your reply. > > Thanks and regards, > > > > On Fri, Jul 13, 2012 at 6:34 PM, Daniel Roßberg <danielmrossb...@gmail.com> > wrote: >> >> I just saw that you added the voxelize.c yesterday ... >> Daniel >> >> 2012/7/13 Daniel Roßberg <danielmrossb...@gmail.com>: >> > Anurag, >> > >> > It's hard to answer your question without seeing your source code. >> > You may commit even buggy code without worry if it isn't used >> > elsewhere, provided that it compiles without warning. >> > >> > However, I would recommend to make the voxelize command similar to >> > facetize. I.e. to have the source object as parameter. >> > >> > BTW, why did you called your file in libanalyze "voxels.c"? And >> > printToScreen() and printToFile() should be defined where it will be >> > used (e.g. in g-voxel.c) and not among the general algorithm in >> > libanalyze(). >> > >> > >> > Regards, >> > Daniel >> > >> > >> > >> > 2012/7/11 Anurag Murty <anuragmu...@gmail.com>: >> >> Daniel (or anyone else who can help me out), >> >> >> >> I am trying to implement the voxelize function in libged. I have a >> >> function >> >> ged_voxelize(struct ged* gedp, int argc ,char *argv[] ) which does the >> >> following : >> >> >> >> I do: >> >> 1. rtip = rt_new_rti(gedp->ged_wdbp->dbip); >> >> 2. then i use rt_gettree to get the command line arguments which user >> >> wants >> >> ion raytrace >> >> 3. then i use rt_prep_parallel(rtip,1) to get the bounding box etc >> >> which is >> >> required for the voxelize command >> >> >> >> However after this when i try to output data related to the bounding >> >> box i >> >> am getting incorrect results. This means that (rtip->mdl_min)[0] etc do >> >> not >> >> give the correct output. Is there a problem in my implementation? If >> >> so, can >> >> someone please point it out? Actually when i call voxelize from >> >> ged_voxelize >> >> after this i get segmentation fault also. >> >> >> >> Thanks and regards, >> >> -- >> >> Anurag Murty >> >> >> >> >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Live Security Virtual Conference >> >> Exclusive live event will cover all the ways today's security and >> >> threat landscape has changed and how IT managers can respond. >> >> Discussions >> >> will include endpoint security, mobile security and the latest in >> >> malware >> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> >> _______________________________________________ >> >> BRL-CAD Developer mailing list >> >> brlcad-devel@lists.sourceforge.net >> >> https://lists.sourceforge.net/lists/listinfo/brlcad-devel >> >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> BRL-CAD Developer mailing list >> brlcad-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/brlcad-devel > > > > > -- > Anurag Murty > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > BRL-CAD Developer mailing list > brlcad-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/brlcad-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
