Hope you feel better soon! Patches should be in 'unified diff', the format where the first character of the line is usually a '+', '-' or space. You can generate them by doing "svn diff > somechange.patch" from the top level BRL-CAD source directory (containing src/ doc/ include/ doc/ ...).
Please be sure that your tree is up to date by running "svn update" and dealing with any conflicts before generating the patch. Please verify that the code you submit follows the HACKING guidelines (double-check indentation and trailing whitespace) Patches should be manually reviewed before submission to verify that they do what you intended and only what you intended. -Erik On 6/20/13 5:28 AM, "Isaac Kamga" <[email protected]> wrote: > Although I have been ill of malaria since Tuesday evening , I worked > on some header files like raytrace.h and db5.h during the morning > periods . I will update my log and upload patches by the end of > today. > > Regards > Izak > > On 6/19/13, [email protected] > <[email protected]> wrote: >> Send brlcad-devel mailing list submissions to >> [email protected] >> >> To subscribe or unsubscribe via the World Wide Web, visit >> https://lists.sourceforge.net/lists/listinfo/brlcad-devel >> or, via email, send a message with subject or body 'help' to >> [email protected] >> >> You can reach the person managing the list at >> [email protected] >> >> When replying, please edit your Subject line so it is more specific >> than "Re: Contents of brlcad-devel digest..." >> >> >> Today's Topics: >> >> 1. Re: [brlcad-commits] SF.net SVN: brlcad:[55793] >> brlcad/trunk/src/libbrep/intersect.cpp (Christopher Sean Morrison) >> 2. Re: GSoC Coding ( phoenix ) >> 3. Re: [brlcad-commits] SF.net SVN: >> brlcad:[55793]brlcad/trunk/src/libbrep/intersect.cpp ( phoenix ) >> 4. Re: GSoC Coding (Vlad Bogolin) >> 5. Re: GSoC Coding (kEsHa sHaH) >> 6. Re: GSoC Coding (Check Nyah) >> 7. Re: GSoC Coding (H.S.Rai) >> >> >> ---------------------------------------------------------------------- >> >> Message: 1 >> Date: Tue, 18 Jun 2013 03:41:01 -0400 >> From: Christopher Sean Morrison <[email protected]> >> Subject: Re: [brlcad-devel] [brlcad-commits] SF.net SVN: >> brlcad:[55793] brlcad/trunk/src/libbrep/intersect.cpp >> To: [email protected] >> Message-ID: <[email protected]> >> Content-Type: text/plain; charset=us-ascii >> >> >> On Jun 17, 2013, at 10:38 AM, [email protected] wrote: >> >>> Revision: 55793 >>> http://sourceforge.net/p/brlcad/code/55793 >>> Author: phoenixyjll >>> Date: 2013-06-17 14:38:53 +0000 (Mon, 17 Jun 2013) >>> Log Message: >>> ----------- >>> The tolerance should be considered in the IsPointIn() test. >> [snip] >>> - bu_log("PCI called.\n"); >>> + if (tolerance <= 0.0) >>> + tolerance = 0.01; >> >> Introducing new magic numbers such as this one should be avoided. It is >> invariably brittle and, in the long term, bug-prone. Suggest using >> something already defined such as BN_TOL_DIST or RT_DOT_TOL or RT_LEN_TOL or >> VUNITIZE_TOL or ... etc. Still, any constant rationale/need should also >> just be documented. >> >> Why 0.01? Why not 0.001 or 0.1 or 0.02? What's the sensitivity and >> rationale? That should all be documented right there with the value (less >> important if it's a defined TOL, but still good to have). >> >> Yes there are lots of places we fail to do this. That's why it's important >> to not introduce any new ones! :) Feel free to fix any others as well, but >> do test. >> >> Cheers! >> Sean >> >> >> >> >> ------------------------------ >> >> Message: 2 >> Date: Tue, 18 Jun 2013 16:11:51 +0800 >> From: " phoenix " <[email protected]> >> Subject: Re: [brlcad-devel] GSoC Coding >> To: " BRL-CAD Developer Mailing List " >> <[email protected]> >> Message-ID: <[email protected]> >> Content-Type: text/plain; charset="iso-8859-1" >> >>> One day of GSoC coding is over, and we have not heard anything from >>> you. You needed to be vocal, interactive on mailing list (or IRC). >>> Keep your daily diary updated. >> >> I worked on point-curve intersections and tests yesterday, and made two >> commits (55793 and 55794). I also updated my development log at: >> http://brlcad.org/wiki/User:Phoenix/GSoc2013/Reports >> >> >> Since I'm having several final exams this week, I moved some of the work >> scheduled this week forward. I have work on point related intersections (and >> have commits) during the past few weeks. >> >> >> Cheers! >> Wu >> -------------- next part -------------- >> An HTML attachment was scrubbed... >> >> ------------------------------ >> >> Message: 3 >> Date: Tue, 18 Jun 2013 16:35:56 +0800 >> From: " phoenix " <[email protected]> >> Subject: Re: [brlcad-devel] [brlcad-commits] SF.net SVN: >> brlcad:[55793]brlcad/trunk/src/libbrep/intersect.cpp >> To: " BRL-CAD Developer Mailing List " >> <[email protected]> >> Message-ID: <[email protected]> >> Content-Type: text/plain; charset="iso-8859-1" >> >>> Introducing new magic numbers such as this one should be avoided. It is >>> invariably brittle and, in the long term, bug-prone. Suggest using >>> something already defined such as BN_TOL_DIST or RT_DOT_TOL or RT_LEN_TOL >>> or VUNITIZE_TOL or ... etc. Still, any constant rationale/need should >>> also just be documented. >> >>> Why 0.01? Why not 0.001 or 0.1 or 0.02? What's the sensitivity and >>> rationale? That should all be documented right there with the value (less >>> important if it's a defined TOL, but still good to have). >> >> I changed to use 0.001 because it's the default tolerance for intersections >> (curve/curve, curve/surface and surface/surface) defined by openNURBS (see >> other/openNURBS/curve.h and other/openNURBS/surface.h). Although openNURBS >> doesn't have point related intersections, I think it's OK to keep the >> tolerance the same for PCI and PSI. But for point/point intersections, I >> make the default tolerance ON_ZERO_TOLERANCE because it should have much >> better accuracy. >> >> >> I modified the code to use macros (PCI_DEFAULT_TOLERANCE and >> PSI_DEFAULT_TOLERANCE) to represent the magic numbers, and added some >> comment to document them. I'm doing some tests to make sure it works well. >> >> >> Cheers! >> Wu >> -------------- next part -------------- >> An HTML attachment was scrubbed... >> >> ------------------------------ >> >> Message: 4 >> Date: Tue, 18 Jun 2013 12:30:18 +0300 >> From: Vlad Bogolin <[email protected]> >> Subject: Re: [brlcad-devel] GSoC Coding >> To: BRL-CAD Developer Mailing List >> <[email protected]> >> Message-ID: >> <CA+5rdc+MBmeCbo-S8Nf=sb9a-hpjxwftrhvezej3fqn0ovf...@mail.gmail.com> >> Content-Type: text/plain; charset="iso-8859-1" >> >> After discussing with my mentor we decided that I should work to integrate >> qt in the cmake build. So, I worked on the cmake and qt integration. I also >> updated my log page: http://brlcad.org/wiki/User:Vladbogolin/GSoC2013/Logs. >> >> Have a nice day, >> Vlad >> -------------- next part -------------- >> An HTML attachment was scrubbed... >> >> ------------------------------ >> >> Message: 5 >> Date: Tue, 18 Jun 2013 19:57:34 +0530 >> From: kEsHa sHaH <[email protected]> >> Subject: Re: [brlcad-devel] GSoC Coding >> To: [email protected] >> Message-ID: >> <calhv3tlc0jfs74qubsdtaf0hgqckrifuy+yxd-nw+ltfewn...@mail.gmail.com> >> Content-Type: text/plain; charset="iso-8859-1" >> >>> One day of GSoC coding is over, and we have not heard anything from >>> you. You needed to be vocal, interactive on mailing list (or IRC). >>> Keep your daily diary updated. >> >>> Discuss your struggle, failure, and success as well. >> >> I have been updating my logs and reports on wiki-page. In that, I have >> mentioned in short about the struggle I face and how did I overcame it. >> >> Link to logs is also embedded with project proposal. >> >> Thanks. >> >> Cheers ! >> >> Regards, >> -- >> Kesha Shah. >> -------------- next part -------------- >> An HTML attachment was scrubbed... >> >> ------------------------------ >> >> Message: 6 >> Date: Tue, 18 Jun 2013 21:03:11 +0100 >> From: Check Nyah <[email protected]> >> Subject: Re: [brlcad-devel] GSoC Coding >> To: BRL-CAD Developer Mailing List >> <[email protected]> >> Message-ID: >> <CA+W8M+8QK0mX8zo7=Lf_xLKoP=ggk4qv5ntan+pveeetpf-...@mail.gmail.com> >> Content-Type: text/plain; charset=ISO-8859-1 >> >> well just recovered from some brief malaria that started last week. So >> will start studying the BRL-CAD libraries tomorrow to work on my >> project. Just wanted to know if there is an implementation of the >> inverse of a 4x4 matrix in the source code before I reinvent the >> wheel. >> >> Regards, >> Nyah >> >> On 6/18/13, kEsHa sHaH <[email protected]> wrote: >>>> One day of GSoC coding is over, and we have not heard anything from >>>> you. You needed to be vocal, interactive on mailing list (or IRC). >>>> Keep your daily diary updated. >>> >>>> Discuss your struggle, failure, and success as well. >>> >>> I have been updating my logs and reports on wiki-page. In that, I have >>> mentioned in short about the struggle I face and how did I overcame it. >>> >>> Link to logs is also embedded with project proposal. >>> >>> Thanks. >>> >>> Cheers ! >>> >>> Regards, >>> -- >>> Kesha Shah. >>> >> >> >> >> ------------------------------ >> >> Message: 7 >> Date: Wed, 19 Jun 2013 07:00:46 +0530 >> From: "H.S.Rai" <[email protected]> >> Subject: Re: [brlcad-devel] GSoC Coding >> To: BRL-CAD Developer Mailing List >> <[email protected]> >> Message-ID: >> <CAGEhASy=a-pmtm93v3stft3czwbrjpe7zbo-jk4yke0ahi4...@mail.gmail.com> >> Content-Type: text/plain; charset=ISO-8859-1 >> >> On Wed, Jun 19, 2013 at 1:33 AM, Check Nyah <[email protected]> wrote: >>> >>> well just recovered from some brief malaria that started last week. >> >> Nyah and all other GSOCers >> >> It is must to keep your self in good health. Only a health person can >> do good coding. Say no to junk food. Have healthy food on time, have >> some physical exercise, observe time schedule. In that way you will be >> more productive >> >> Never do "Top posting", and trim mails. >> >> In case you need more information, read: >> >> http://www.networketiquette.net/ >> >> http://www.slideshare.net/fullscreen/sandeepkmadaan/mailing-guidelines/2 >> >> -- >> H.S.Rai >> >> >> >> ------------------------------ >> >> ----------------------------------------------------------------------------->> - >> This SF.net email is sponsored by Windows: >> >> Build for Windows Store. >> >> http://p.sf.net/sfu/windows-dev2dev >> >> ------------------------------ >> >> _______________________________________________ >> brlcad-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/brlcad-devel >> >> End of brlcad-devel Digest, Vol 331, Issue 1 >> ******************************************** >> > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > BRL-CAD Developer mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/brlcad-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
