Hi Kalpit,
At first glance it looks OK. However, Pipe.cpp isn't so important as the
core interface follows slightly different conventions, but the tests should
follow the HACKING.
Good luck with your exams!
Regards
Daniel
2015-04-21 15:21 GMT+02:00 Kalpit Thakkar <ceasy...@gmail.com>:
> Hi Daniel,
> I'm sorry for making such a mess of formatting conventions. I have
> attached Pipe.cpp that I tried to make such that it follows the indentation
> rules that you mentioned in your comment. Please review it and tell me if
> that's alright. If so, I'll upload the final patch.
>
> With Regards,
> Kalpit
>
> PS : A small reminder. I will be busy with my exams till 29th. I will
> upload the patch in between if required. :)
>
> Pipe.cpp
> <https://docs.google.com/file/d/0B12fowx3-NjTNm1jeFdrLXNoYlk/edit?usp=drive_web>
>
> On Tue, Apr 7, 2015 at 4:17 PM, Kalpit Thakkar <ceasy...@gmail.com> wrote:
>
>> Hello Daniel!
>> I have written the tests for the Pipe implementation and I faced some
>> problems while running the tests. Well, I was onto it since two days and
>> finally, I did solve the problems I was facing. I have listed the problems
>> in short here :
>>
>> https://gist.github.com/dracarys-stormborn/10cfb93644297222dbd9
>>
>> Some changes I mentioned in my previous mail were wrong. The final
>> patches have been submitted on sourceforge (here
>> <https://sourceforge.net/p/brlcad/patches/300/#7fa7>). Please have a
>> look whenever possible.
>> Well, there is one suggestion. I think we should have one method to get
>> the number of control points in our class implementation, maybe? It's a
>> small one liner, yes, but I guess it is important.
>>
>> With Regards,
>> Kalpit Thakkar
>>
>> PS : You can find the details about the work here :
>> https://brlcaddev.wordpress.com/development-logs-for-pre-community-bonding-period/
>>
>> On Fri, Apr 3, 2015 at 10:34 PM, Kalpit Thakkar <ceasy...@gmail.com>
>> wrote:
>>
>>> Hi Daniel.
>>> I have reviewed the latest patch uploaded by Andrei Ilinca and I thought
>>> there were some things still to be added / changed. You can find the
>>> additions / changes here :
>>>
>>> https://gist.github.com/dracarys-stormborn/0da301c03fb34c8a6e9a
>>>
>>> Besides these changes, the patch submitted by Ilinca is all good.
>>> If there is anything more that is to be added yet, tell me and I'll be
>>> on it. :D
>>> I have started writing the tests for the existing Pipe implementation
>>> with these changes that I have done. I'll get back to you on it tomorrow.
>>>
>>> Tell me if there is any issue with the changes :)
>>>
>>> With Regards,
>>> Kalpit Thakkar
>>>
>>> On Thu, Apr 2, 2015 at 9:56 PM, Daniel Roßberg <
>>> danielmrossb...@gmail.com> wrote:
>>>
>>>> You could test it with the latest patch. I'm rather sure that nobody
>>>> has done this yet.
>>>>
>>>> Daniel
>>>>
>>>> 2015-04-02 15:00 GMT+02:00 Kalpit Thakkar <ceasy...@gmail.com>:
>>>> > Hello Daniel!
>>>> > I have been wondering about what to do about the Pipe implementation
>>>> done by
>>>> > Andrei Popescu. Do you have any suggestions regarding where to start?
>>>> What
>>>> > are the things that might require improvement? Is anything to be
>>>> added?
>>>> >
>>>> > I'm sorry I am late on my schedule on this. I am ready to work on it
>>>> now.
>>>> > I'll try my best to get it right and get it merged in the time frame
>>>> > designated for it in my proposal. Awaiting your reply. :)
>>>> >
>>>> > With Regards,
>>>> > Kalpit Thakkar
>>>> >
>>>> >
>>>> >
>>>> ------------------------------------------------------------------------------
>>>> > Dive into the World of Parallel Programming The Go Parallel Website,
>>>> > sponsored
>>>> > by Intel and developed in partnership with Slashdot Media, is your
>>>> hub for
>>>> > all
>>>> > things parallel software development, from weekly thought leadership
>>>> blogs
>>>> > to
>>>> > news, videos, case studies, tutorials and more. Take a look and join
>>>> the
>>>> > conversation now. http://goparallel.sourceforge.net/
>>>> > _______________________________________________
>>>> > BRL-CAD Developer mailing list
>>>> > brlcad-devel@lists.sourceforge.net
>>>> > https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>>> >
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Dive into the World of Parallel Programming The Go Parallel Website,
>>>> sponsored
>>>> by Intel and developed in partnership with Slashdot Media, is your hub
>>>> for all
>>>> things parallel software development, from weekly thought leadership
>>>> blogs to
>>>> news, videos, case studies, tutorials and more. Take a look and join the
>>>> conversation now. http://goparallel.sourceforge.net/
>>>> _______________________________________________
>>>> BRL-CAD Developer mailing list
>>>> brlcad-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>>>
>>>
>>>
>>
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live
> exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> BRL-CAD Developer mailing list
> brlcad-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>
>
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
