Hi ，
Has anyone reviewed my patch https://sourceforge.net/p/brlcad/patches/432/
?
Is it ok? Or should I refractor the three
function “nmg_findeu”,”nmg_find_eu_in_face”,”nmg_find_e” in
src/librt/primitives/nmg/nmg_info.c straightly?
And about the regression test, I just run “make
test” and make the result the same as when I didn't do anything to the code. Or
should I write the regression test by myself?Anyone's help is welcome.
Thanks,
PAN LILI (Lily)
From: lily19930...@outlook.com
To: brlcad-devel@lists.sourceforge.net
Date: Fri, 11 Mar 2016 13:04:17 +0000
Subject: Re: [brlcad-devel] GSoC: patch for Code Reduction
Hi Sean，
Thanks for your guidance. It really helps
me.
I’m going to apply for the project “Code
Reduction”, http://brlcad.org/wiki/Code_Reduction.
And I have submitted a patch to refractor
the duplicate code (#432). Kindly review it.
PAN LILI (Lily)
From: brl...@mac.com
Date: Tue, 8 Mar 2016 17:07:53 -0500
To: brlcad-devel@lists.sourceforge.net
Subject: Re: [brlcad-devel] GSoC: help for Code Reduction
On Mar 6, 2016, at 10:27 AM, PANLILI <lily19930...@outlook.com> wrote:Hi，I am
working for “Code Reduction”, http://brlcad.org/wiki/Code_Reduction. When I use
simian to check duplicate code, it's result is what the picture below shows.
<捕获.PNG> Is there really no duplicate coding or just I use simian in a wrong
way?If the latter,where is wrong?Anyone's help is welcome.
Lily,
At a glance, it looks like the paths you specified are not right. You need to
specify the path the files that Simian is to analyze. You specified a
“~brlcad” and “**/*.h” directories, which don’t look right. What is right will
depend on where you put the BRL-CAD sources (nobody can tell you).
Sean
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://makebettercode.com/inteldaal-eval
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
