Rakshika,
Some comments:
The typedefs in DCEL.h look unusual to me. You probably just want to
forward declare some structs. But to declare a struct you simply need
to write "struct <name>;" and you only need one struct there:
DCEL_Edge. The others don't need to be forward declared.
And, a class with only public members is in fact a struct ;)
There are several issues with your PolygonialMesh class.
First, it has a lot of set-functions without any parameter. What do they set?
Secondly, you handle potentially large vector structures always by
value which means that a lot of copying has to be done there. You
should handle them by reference whenever possible.
And, PolygonialMesh (or another class? DCEL? but hidden behind
PolygonialMesh) should manage the double connected edge list and
guarantee its consistency. Every change of this list should be done
by specific access functions. You shouldn't leave this to the user of
the PolygonialMesh class. Keeping the double connected edge list in
shape is a nontrivial task.
Regarding the CAD specific implementations: There are several missing
return statements.
All-in-all you have still a long way to go.
Regards,
Daniel
2016-06-03 22:19 GMT+02:00 Rakshika Bagavathy <rakshika.bagava...@gmail.com>:
> Daniel,
>
> I'm attaching the link to the code i've written. I'm getting an error with
> the OpenSCAD conversion file regarding the constructor. And one with the
> BRL-CAD conversion file with the rt_bot_same_orientation() definition (this
> occurred after i moved definitions to the header files). Please let me know
> about any changes i need to make. I will get started on the TCL command.
>
> https://drive.google.com/open?id=0B7N8x571Yp6VY2NhN3M1d1lHcVk
>
> Regards,
> Rakshika
>
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> _______________________________________________
> BRL-CAD Developer mailing list
> brlcad-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
