Hi,
Sean has left the following comment at Create numerics library (LIBBN) API
unit test ... for list.c
http://www.google-melange.com/gci/task/view/google/gci2012/8000211:
looks great but...
Lachlan, the test looks almost perfect. It's in the build right and looks
like a reasonable set of tests but the implementation has a few issues. The
biggest is the use of fmemopen(), which is a no-go.
That's a posix 2008 function that's not even c99-compliant, which we don't
allow be a requirement. You'll need to find an alternate method either by
using libbu's mapped_file interface (VERY similar) or simpler allocation
and not relying on FILE*'s.
The other issue I noticed is you're cailing some functions that we wrap for
portability and security. See our HACKING file for a list, but I at least
noticed strncmp(), which should be replaced with the libbu version. HACKING
has more details.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Create
numerics library (LIBBN) API unit test ... for list.c.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2012/8000211.
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve.
http://goparallel.sourceforge.net
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
