Hi,

Sean has left the following comment at Investigate performance of setting thread affinity http://www.google-melange.com/gci/task/view/google/gci2012/7960222:


few issues


Skriptkid, the indentation and style is STILL wrong... :) Please review our HACKING file for details, but open curly braces go on the same line as their statements (except for functions) and sequences of 8 spaces need to be tabs (we use tab+space to indent levels are 4 spaces, 1 tab, 1tab+4spaces, 2 tabs, 2tabs+4spaces, etc). Getting the style right isn't optional.

The implementation seems reasonable, but the testing seems a bit flawed. Setting affinity within a VM isn't likely to make a difference (and the benchmark numbers reflect that). Moreover, the patch only includes changes to parallel.c and not any other files you changed. Run "svn diff" from the top src directory to get a patch for all changes.


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Investigate performance of setting thread affinity. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/7960222.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to