Hi,

Sean has left the following comment at Verify and/or Fix setting cflags/cppflags/ldflags during Cmake http://www.google-melange.com/gci/task/view/google/gci2012/7984228:


now it becomes more clear


Now it's more clear what you actually changed... :)

So that's looking good but a couple issues. First, you shouldn't leave commented out code (it's dead code). Second, you're eliminating a feature by commenting out the $ENV() lines -- those pull flag settings from environment variables. They should probably be changed to append to end of the cmake flag variables.


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Verify and/or Fix setting cflags/cppflags/ldflags during Cmake. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/7984228.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to