Hi,
Sean has left the following comment at Fix CMake build system
auto-disabling of GLEW
http://www.google-melange.com/gci/task/view/google/gci2012/7999218:
glew patch
So the glew patch identifies the problem as trying to compile glew.c when
we don't need to, but the fix shouldn't replicate the entire list of source
files. Try to adhere to the "DRY" principle:
http://en.wikipedia.org/wiki/Don't_repeat_yourself
We fail at it ourselves sometimes, but it's an important guideline to
follow especially when adding new logic/code.
Also be careful of stray edits. Your first patch included a seemingly
unrelated change to src/libfb/tcl.c (review changes via "svn diff" before
commit is a good habit).
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Fix CMake
build system auto-disabling of GLEW.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2012/7999218.
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
