Hi,

Sean has left the following comment at Create a numerics library (LIBBN) API unit test ... for poly.c http://www.google-melange.com/gci/task/view/google/gci2012/7984226:


indentation


What did you do to change the indentation? It looks the same to me. You fixed the else statements, but that pointed out a different usability issue. If an 'else' statement requires brackets, you should put them on the 'if' statement too even if it's a one-liner that doesn't technically need it.

Not good:

if (whatever)

printf("hello");

else {

printf("hello");

printf("hello2");

}


Good:

if (whatever {

printf("hello");

} else {

printf("hello");

printf("hello");

}


Still, don't overlook the indentation style. 4spcs, 1tab, tab+4spcs, 2tabs, etc.


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Create a numerics library (LIBBN) API unit test ... for poly.c. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/7984226.

------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to