Hi,
Sean has left the following comment at Create a utility library (LIBBU) API
unit test ... for vlb.c
http://www.google-melange.com/gci/task/view/google/gci2012/8036205:
looks good
Only noticed a few issues on quick inspection:
You should be using bu_malloc() and bu_free() instead of malloc() and
free() directly. See our HACKING file for a list of functions that are
replaced by our libbu versions for portability.
The open parenthesis on main() should be on a line by itself (functions are
formatted differently). The return type should be by itself too.
Your call to pipe() -- that block needs to be wrapped in HAVE_PIPE (see
src/mged/mged.c for an example) as it's not portable.
Header is missing common.h (see HACKING)
Memory allocations are "unclean", must bu_free() before return/exit even in
the error blocks (in case this main() ever turned into a non-main()
function. A goto is acceptable if you want to consolidate but make sure you
still don't free a null pointer.
Use of // is no good (see HACKING). Use /* comment */ instead.
The "documentation in the CMakeLists.txt file is great, but you should have
some similar sort of summary comment in the source file as well.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Create a
utility library (LIBBU) API unit test ... for vlb.c.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2012/8036205.
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
