Hi,

Sean has left the following comment at Add a primitive surface area function ... for right hyperbolic cylinders (RHC) http://www.google-melange.com/gci/task/view/google/gci2012/7982218:


looks great


Thanks Aaron, that looks good. Your patch has been applied as r54145 (and you are already credited in our authorship documentation) with some minor changes.

For what it's worth, you usually want to avoid indentation levels if they're avoidable. It's a minor stylistic point, but you'll usually want to validate your input parameters and exit early.


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Add a primitive surface area function ... for right hyperbolic cylinders (RHC). To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/7982218.

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to