Patches item #3610098, was opened at 2013-04-05 09:07 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3610098&group_id=105292
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Analysis >Group: Untested >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Csaba Nagy (ncsaba) >Assigned to: Sean Morrison (brlcad) Summary: Refactor pipe element calculation in pipe.c Initial Comment: The calculation of the linear/bent elements needed to construct a pipe based on it's control points is repeated a few times in the code. This patch is extracting it in a separate function, and replaces 2 of the occurrences with call to this new function. There is one more occurrence in the rt_pipe_tess function, but that code has either already drifted or it really does something different, so I didn't touch it - needs review from somebody who knows that code. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2013-04-11 21:15 Message: Almost a perfect patch! It applied cleanly but had numerous whitespace/indent inconsistency errors. You might want to run sh/ws.sh on your file before making future patches/commits or reviewing the indentation rules described in our HACKING file. Applied in r55134. Your name is reflected in our AUTHORS file too. Thanks! ---------------------------------------------------------------------- Comment By: Csaba Nagy (ncsaba) Date: 2013-04-11 12:04 Message: adrisons: the path is src/librt/primitives/pipe/pipe.c (you can find it in the patch too) Cheers, Csaba ---------------------------------------------------------------------- Comment By: adrisons (adrisons) Date: 2013-04-10 13:31 Message: Hi, sorry for this stupid question but i've never used sourceforge, how can i see where the file pipe.c is located? ---------------------------------------------------------------------- Comment By: Csaba Nagy (ncsaba) Date: 2013-04-07 03:30 Message: Patch version 1 uploaded. ---------------------------------------------------------------------- Comment By: Csaba Nagy (ncsaba) Date: 2013-04-05 10:54 Message: This solution is not satisfactory, I will work on a new patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3610098&group_id=105292 ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ BRL-CAD Tracker mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
