Hi,

tannousmarc has left the following comment at Identify and eliminate dead code (100+ lines) https://www.google-melange.com/gci/task/view/google/gci2014/5893656028381184:


What I did


First, I tried using simian on my VM, and after 2 hours of letting it work I realized that there is no point in doing that and finally got together and started installing a Debian which runs in Dual boot with windows 8.1 .

This seemed like an easy task, but for someone that has 2 weeks of practice in a VM of Linux, this was not the case. I learned that everything in Linux needs to be package installed, learned a bunch of terminal commands to ease my job and had to ask a lot of questions on IRC, but in the end I got a somewhat stable build of BRL-CAD running on Debian 7.5, after about 6 hours.

After that, running simian took 3 seconds and I quickly found some duplicate code I could remove in two Factory.cpp files.

My solution was simple : add the duplicated code in a common library.

Upon more research, they both had a Factory.h library in their respective folders and both Factory.hs had the exact same code, so I deleted those, and created a Factory.h library in their parent directory that they both now use, where I added the duplicate code.

Overall, I added 200 lines of code, and erased 760, so I removed around 560 lines of duplicate code, I think I went a little bit overboard.

Hope what I did makes sense, and if it does not then I will try my best at fixing it. I am now exhausted, will go to bed, it's been a great ( but stressful ) day.

Regards,

Marc


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Identify and eliminate dead code (100+ lines). To stop receiving these messages, go to: https://www.google-melange.com/gci/task/view/google/gci2014/5893656028381184.

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to