Hi,
brlcad has left the following comment at Visualize ray bundling #2
https://www.google-melange.com/gci/task/view/google/gci2014/5323147989483520:
one minor thing
Oof, you're definitely starting to poke a hornets nest now... ;)
So this looks fantastic, the visualizations are perfect. Heck, I didn't
even realize that's what the rt_raybundle_maker sampling looked like...
That said, changing that already-published function's API violates our
CHANGES contract as it's not a minimally impacting. I'll have to talk with
some people to see if this will break their usage. This is our problem to
sort out, though, as the change seems reasonable at first glance (we just
can't release until we resolve this).
We really probably want a hybrid of shootrays and bundle_maker because I
think an array will be more desirable long-term than a linked list, but
that's a change for another day.
That said, that's not the reason I marked this as needing more work. That
was simply because you modified rtshot with new command-line options and
don't document them in doc/docbook/system/man1/en/rtshot.xml! They go hand
in hand. ;)
On that note, instead of -A, you should probably use -p for perspective
angle so it's consistent with the other rt* tools. Also, the help text for
-c and -l indicate they're the same thing. Perhaps you meant -c is per
<ring/radius/depth> or <ring/radius/width> or perhaps you did mean
<ring/radius/length> and -l needs to be -d and use some other word like
dimensions. But then if they're dimensions, then what is -c length supposed
to mean for a rect/frustum type? For that matter, does -l also apply to
frustum grids?
Just some minor consistency clean-up and careful wording should clear that
up quickly.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Visualize ray
bundling #2.
To stop receiving these messages, go to:
https://www.google-melange.com/gci/task/view/google/gci2014/5323147989483520.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
