Hi,
brlcad has left the following comment at Design new API function to reduce
duplication #2
https://www.google-melange.com/gci/task/view/google/gci2014/5256821832941568:
time to digest
It'll take a bit to digest everything going on in here, but on the surface
it looks workable but needing reduction. Just to pick one needle out of the
haystack, I'm not sure I see the value in rt_ray_bundle_set() or
rt_ray_bundle_next_n_rays() needing to exist. I know those are your
streamers, but they're functionally no different than
rt_ray_bundle_get_n_rays(). A streaming API is something of a different
beast altogether.
I also don't think you should follow suit like some of our other structs
and expose private data in the API. Better is a declared private structure
or a simple void* or other hiding mechanism that is defined by a private
header and only known to the implementations. The entire caching mechanism
belongs in there.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Design new API
function to reduce duplication #2.
To stop receiving these messages, go to:
https://www.google-melange.com/gci/task/view/google/gci2014/5256821832941568.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
