Hi,
brlcad has left the following comment at Eliminate any library global
variable #6
https://www.google-melange.com/gci/task/view/google/gci2014/4984285001940992:
static
Jacob, this looks good, but you only moved the bu_n_malloc global. To
eliminate it, you must at least mark it static in malloc.c and you'll need
to protect it from multithreaded access
(bu_semaphore_acquire/bu_semaphore_release) when adding to it.
That said, anytime a function or global variable are not global scope, they
should not have the bu_ prefix, so malloc_add() would be a better name.
Also suggest renaming to bu_malloc_get() so that it matches the convention
in our HACKING file of LIB_GROUP_VERB() on function names.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Eliminate any
library global variable #6.
To stop receiving these messages, go to:
https://www.google-melange.com/gci/task/view/google/gci2014/4984285001940992.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
