----- Original Message -----
>
>
> ----- Original Message -----
> > [quoted lines by Jaroslav Skarvada on 2018/04/24 at 16:49 -0400]
> >
> > >It didn't work for me. There is original build log:
> > >https://kojipkgs.fedoraproject.org/packages/brltty/5.6/7.fc29/data/logs/x86_64/build.log
> >
> > okay, I didn't fully understand. The latest commit should fix it. Please
> > retest.
> >
> Thanks, it works for me. I used the patch in Fedora downstream
>
> regards
>
> Jaroslav
> _______________________________________________
> This message was sent via the BRLTTY mailing list.
> To post a message, send an e-mail to: [email protected]
> For general information, go to: http://brltty.com/mailman/listinfo/brltty
>
Hi,
I received report that the LDFLAGS are still not taken into account for
libbrlapi
and corresponding bindings. I used the attached patch downstream in addition to
your patch
thanks & regards
Jaroslav
diff --git a/Bindings/Java/Makefile.in b/Bindings/Java/Makefile.in
index b0a6e1c..5982742 100644
--- a/Bindings/Java/Makefile.in
+++ b/Bindings/Java/Makefile.in
@@ -52,7 +52,7 @@ JAVA_JNI_FILE = $(LIB_PFX)$(API_NAME)_java.$(LIB_EXT)
jni: $(JAVA_JNI_FILE)
$(JAVA_JNI_FILE): bindings.$O $(API_NAME)
- $(MKLIB:<name>=$(API_NAME)) $@ bindings.$O $(API_LDFLAGS)
+ $(MKLIB:<name>=$(API_NAME)) $@ bindings.$O $(API_LDFLAGS) $(LDFLAGS)
bindings.$O:
$(CC) $(LIBCFLAGS) $(JAVA_JNI_FLAGS) -o $@ -c $(SRC_DIR)/bindings.c
diff --git a/Bindings/OCaml/Makefile.in b/Bindings/OCaml/Makefile.in
index 47f7201..469f41e 100644
--- a/Bindings/OCaml/Makefile.in
+++ b/Bindings/OCaml/Makefile.in
@@ -55,13 +55,13 @@ OCAML_FILES = $(OCAML_MISC) $(OCAML_CLIBS) $(OCAML_BCLIB) $(OCAML_NCLIB)
all : $(OCAML_FILES)
$(OCAML_CLIBS) : brlapi_stubs.$O brlapi
- $(OCAMLMKLIB) $(API_LDFLAGS) -oc $(OCAML_LIB)_stubs brlapi_stubs.$O
+ $(OCAMLMKLIB) -ldopt "$(LDFLAGS)" $(API_LDFLAGS) -oc $(OCAML_LIB)_stubs brlapi_stubs.$O
$(OCAML_BCLIB) : $(OCAML_CLIBS) brlapi.cmo
$(OCAMLC) -a $(OCAMLMKLIB_FLAGS) -o $(OCAML_LIB).cma brlapi.cmo
$(OCAML_NCLIB) : $(OCAML_CLIBS) brlapi.cmx
- $(OCAMLMKLIB) $(OCAMLMKLIBOPT_FLAGS) -o $(OCAML_LIB) brlapi.cmx
+ $(OCAMLMKLIB) -ldopt "$(LDFLAGS)" $(OCAMLMKLIBOPT_FLAGS) -o $(OCAML_LIB) brlapi.cmx
brlapi.cmi: brlapi.mli
$(OCAMLC) -o $@ -c brlapi.mli
diff --git a/Bindings/Tcl/Makefile.in b/Bindings/Tcl/Makefile.in
index 683e74e..ceae16f 100644
--- a/Bindings/Tcl/Makefile.in
+++ b/Bindings/Tcl/Makefile.in
@@ -30,7 +30,7 @@ TCL_API = $(LIB_PFX)$(API_NAME)_tcl.$(LIB_EXT)
all: $(TCL_API)
$(TCL_API): bindings.$O $(API_NAME)
- $(MKLIB:<name>=$(API_NAME)) $@ bindings.$O $(TCL_LIBS) $(API_LDFLAGS)
+ $(MKLIB:<name>=$(API_NAME)) $@ bindings.$O $(TCL_LIBS) $(API_LDFLAGS) $(LDFLAGS)
bindings.$O:
$(CC) $(TCL_CPPFLAGS) $(LIBCFLAGS) -o $@ -c $(SRC_DIR)/bindings.c
diff --git a/Programs/Makefile.in b/Programs/Makefile.in
index 0016035..5297a8b 100644
--- a/Programs/Makefile.in
+++ b/Programs/Makefile.in
@@ -613,7 +613,7 @@ $(API_LIB_VERSIONED): $(API_LIB)
api-dynamic-library: $(API_LIB)
$(API_LIB): $(API_CLIENT_OBJECTS)
- $(MKLIB:<name>=${API_LIB_VERSIONED}) $@ $(API_CLIENT_OBJECTS) $(API_LIBRARIES)
+ $(MKLIB:<name>=${API_LIB_VERSIONED}) $@ $(API_CLIENT_OBJECTS) $(API_LIBRARIES) $(LDFLAGS)
api-dynamic-library-windows: $(API_DLL)
$(API_DLL): $(API_CLIENT_OBJECTS)
_______________________________________________
This message was sent via the BRLTTY mailing list.
To post a message, send an e-mail to: [email protected]
For general information, go to: http://brltty.app/mailman/listinfo/brltty
