On Sat, Nov 03, 2012 at 22:01 +0000, you wrote: > I tested master, and it wasn't working properly for me. I traced the > problem to the simplification of DNS_Mgr::AsyncLookupName.
Ah, I wasn't looking right it seems. With that, joining the functions actually doesn't look like a good change, so I'm going to move this back to your original implementation. Sorry about the confusion. > on how we'd go about writing some tests for the TXT queries - this was > the one case where being able to load the cache from a file did seem > useful. Yeah, but even that would only test a part of the chain, not the requests themselves. Robin -- Robin Sommer * Phone +1 (510) 722-6541 * [email protected] ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org _______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
