On Dec 5, 2012, at 11:58 PM, Matthias Vallentin <[email protected]> wrote:

>   Implement equivalence relation for opaque types.
>  case TYPE_OPAQUE:
> -    // FIXME: Should we downcast here and compare the opaque type names?
> -    return 1;
> +    {
> +             const OpaqueType* ot1 = (const OpaqueType*) t1;
> +             const OpaqueType* ot2 = (const OpaqueType*) t2;
> +    return ot1->Name() == ot2->Name() ? 1 : 0;
> +    }


When we implement opaque types, shouldn't we be able to supply an equivalency 
testing function?  Just comparing the types seems of limited use.

  .Seth

--
Seth Hall
International Computer Science Institute
(Bro) because everyone has a network
http://www.bro-ids.org/


_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to