I already talked to Matthias but for the record, this looks good to
me.

One more question:

On Tue, Jun 04, 2013 at 15:24 -0700, you wrote:

> (4) bloomfilter_merge(bf1: opaque of bloomfilter, bf2: opaque of
> bloomfilter) : bool

Is this merging bf2 into bf1? Would it make sense to return a new
"opaque of bloomfilter" instead? Alternatively, we might need a
bloomfilter_copy() for the case that one wants to merge without
destroying any of the original filters.

Robin

-- 
Robin Sommer * Phone +1 (510) 722-6541 *     [email protected]
ICSI/LBNL    * Fax   +1 (510) 666-2956 * www.icir.org/robin
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to