On 11/18/2013 09:52 AM, Robin Sommer wrote: > > On Mon, Nov 18, 2013 at 00:00 -0800, you wrote: > >> 3effe5d [1] bro Daniel Thayer 2013-11-15 Update local.bro for >> Bro 2.2 > > Daniel, rathter than simply removing the piece of code, can we put in > a 2.2 version instead to achieve the same effect? > > Robin >
I think it's a bad idea to have script code in local.bro (besides "@load") because it will not be updated when a user upgrades to a newer release of Bro. Also, the fact that it's commented-out by default means it's not going to be tested, and most likely nobody will notice (for a while) when something else changes that breaks that code. Perhaps instead we could put something in scripts/policy/misc/ (or somewhere else?), and then @load that from local.bro (the @load would be commented-out by default). _______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
