[ 
https://bro-tracker.atlassian.net/browse/BIT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006#comment-16006
 ] 

grigorescu commented on BIT-1129:
---------------------------------

Found my trace. I need to sanitize it and will create a test for it.

 * For the expiration logic - you're right, expire should log the entry. I'll 
try to get that a test for that as well.
 * For the attribute list - it's a vector because technically you could have 
multiple entries of the same attribute type. The only place this seems to 
happen in the real world is for the vendor-specific type. I have some code that 
would deal with those types, but it requires some further work (and that won't 
be a base script). I'm not sure what to do in the case that other attribute 
types (e.g. username, calling station id, etc.) are present multiple times. 
It's not a violation of the RFC, so perhaps just a weird?

> RADIUS Protocol Analyzer
> ------------------------
>
>                 Key: BIT-1129
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1129
>             Project: Bro Issue Tracker
>          Issue Type: New Feature
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: grigorescu
>            Assignee: Vlad Grigorescu
>             Fix For: 2.3
>
>
> topic/vladg/radius is ready to be merged. It's been running at CMU for a few 
> months with no issues.



--
This message was sent by Atlassian JIRA
(v6.3-OD-01-067#6307)
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to