[ 
https://bro-tracker.atlassian.net/browse/BIT-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104#comment-16104
 ] 

Robin Sommer commented on BIT-1181:
-----------------------------------

I don't think we should turn this into a fatal error, not even
optionally. Fatal errors should actually never occur during normal
operation.

A different suggestion: we already have a reporter_error() event.
Seems one could just look out for these errors and turn them into a
corresponding notice as part of the site policy.



> Input-framework errors should be fatal (or Notice_Alarm) instead of silent 
> reporter::error failures
> ---------------------------------------------------------------------------------------------------
>
>                 Key: BIT-1181
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1181
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Aashish Sharma
>            Assignee: Bernhard Amann
>              Labels: input-framework
>
> I noticed many times that if there is a problem in a feed file (syntax, or 
> some other issue) and input-framework is unable to read the file, it 
> generates a Reporter::Error. This is a silent failure condition ie bro 
> continues to operate as normal and the error is logged into reporter log. 
> Ideally above is the right thing to do. However, This failure results in no 
> data in the tables getting updated any more while I continue to operate 
> under-impression that Bro is working fine (unless I have explicitly been 
> looking at reporter log for this issue , which now I do). 
> If input-framework is unable to read/digest data from a feed, I believe that 
> should be a (configurable) fatal error or something which at least triggers 
> an alarm/alert/email. 



--
This message was sent by Atlassian JIRA
(v6.3-OD-02-026#6318)
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to