[ 
https://bro-tracker.atlassian.net/browse/BIT-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400#comment-17400
 ] 

Jon Siwek commented on BIT-1222:
--------------------------------

For optional components like the DataSeries writer, if the plugin is not built 
(e.g. missing dependencies), the enum value associated w/ it's tag won't be 
created, but it may still be referenced from scripts that are loaded.  e.g. 
when I compile without DataSeries, tests fail and complain about 
{{Log::WRITER_DATASERIES}} in 
{{scripts/base/frameworks/logging/writers/dataseries.bro}} being an unknown ID.

> topic/robin/reader-writer-plugins
> ---------------------------------
>
>                 Key: BIT-1222
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1222
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Robin Sommer
>            Assignee: Jon Siwek
>             Fix For: 2.4
>
>
> This moves log writers and input readers to the new plugin API. No functional 
> differences, except that one can now implement them via external plugins as 
> well. Test cases for that included.
> Most of the change is just moving stuff around, plus adapting to the new API. 
> There are a few changes to defining/handling of the corresponding builtin 
> types, as they now have to be dynamic.



--
This message was sent by Atlassian JIRA
(v6.4-OD-02-003#64000)
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to