[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18300#comment-18300
]
Robin Sommer commented on BIT-1270:
-----------------------------------
A few comments:
- instead if using a separate wrapper class, what would think about just using
std::tuple<bool, Val*>? I think that would simplify things quite a bit.
- reporter->InternalError() takes a format string, so you can skip the snprintf.
- please try to follow Bro's coding conventions for formatting, the diff is a
bit messy
> topic/gilbert/plugin-api-tweak
> ------------------------------
>
> Key: BIT-1270
> URL: https://bro-tracker.atlassian.net/browse/BIT-1270
> Project: Bro Issue Tracker
> Issue Type: Improvement
> Components: Bro
> Reporter: gclark
>
> This branch makes a few changes to the API:
> * Wraps values in a simple class (ValWrapper) that include an explicit
> processed / not processed flag (to avoid confusion with delayed / opaque
> invocations).
> * Adds a Frame argument to HookCallFunction
> * Adds support for Frame argument types to HookArgument
> * Adds support for ValWrapper argument types to HookArgument
> * Tweaks the plugin.hooks tests a bit to include new output (from additional
> argument)
> * Tweaks the plugin.api-version-mismatch to remove explicit home directory
> path via simple regex
--
This message was sent by Atlassian JIRA
(v6.4-OD-05-009#64003)
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
