I moved that line from NetVar to my plugin source. I also moved some things from bifs to the plugin source (honestly, just copied and pasted). Posting just the plugin directory won't show which lines in the core I moved to the plugin. Should I make a branch off master? What are the general conventions for doing this?
-AK On Oct 15, 2014 8:28 AM, "Seth Hall" <[email protected]> wrote: > > On Oct 15, 2014, at 10:46 AM, Siwek, Jon <[email protected]> wrote: > > > Maybe that can just be completely removed if Bro proper no longer relies > on that type since all the related functionality is now provided by the > plugin? > > Agreed. Any code related to GeoIP should move into the plugin, including > types. > > .Seth > > -- > Seth Hall > International Computer Science Institute > (Bro) because everyone has a network > http://www.bro.org/ > >
_______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
