[
https://bro-tracker.atlassian.net/browse/BIT-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18614#comment-18614
]
Jon Siwek commented on BIT-924:
-------------------------------
Would be nice to change index to start at 0 for consistency, but maybe not
worth suddenly breaking existing code that relies on the 1 based indexing.
Maybe a safe approach is to just make sure these are well-documented to warn
that it's 1 based, then implement alternate versions under slightly different
names (e.g. suffix with a '0') and return 0 based values. Could also think
about removing the old versions, but just changing them in-place seems hard to
warn users about.
> String BIFs Return 1-indexed string_arrays
> ------------------------------------------
>
> Key: BIT-924
> URL: https://bro-tracker.atlassian.net/browse/BIT-924
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: git/master
> Reporter: grigorescu
> Fix For: 2.4
>
>
> The following BIFs return 1-indexed string_arrays:
> * sort_string_array
> * split
> * split1
> * split_all
> * split_n
--
This message was sent by Atlassian JIRA
(v6.4-OD-07-004#64005)
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
