[ 
https://bro-tracker.atlassian.net/browse/BIT-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19204#comment-19204
 ] 

Eric Asselin edited comment on BIT-1298 at 12/9/14 4:03 PM:
------------------------------------------------------------

Here's the code example from NTP.cc:
void NTP_Analyzer::DeliverPacket(int len, const u_char* data, bool is_orig, 
uint64 seq, const IP_Hdr* ip, int caplen)
{
        ip->SrcAddr(); // or assert(ip)
        ...
}


was (Author: easselin):
Here's the code example from NTP.cc:
void NTP_Analyzer::DeliverPacket(int len, const u_char* data, bool is_orig, 
uint64 seq, const IP_Hdr* ip, int caplen)
{
        ip->SrcAddr(); // or assert(ip)
        ...
}

> IP_Hdr pointer do not propagate from udp to child analyzers via DeliverPacket 
> method causing a segfault
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BIT-1298
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1298
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.3
>         Environment: Debian
>            Reporter: Eric Asselin
>            Priority: High
>              Labels: analyzer
>         Attachments: core.zip
>
>
> From a child analyzer like NTP, the IP_Hdr pointer in the DeliverPacket 
> method is empty and unusable causing a segmentation fault as soon as you try 
> to access it.
> To recreate the bug, just add an "assert(ip)" inside the DeliverPacket method 
> of a UDP child analyzer and the execution will fail (instead of the 
> segmentation fault).



--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to