[ 
https://bro-tracker.atlassian.net/browse/BIT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20204#comment-20204
 ] 

Robin Sommer commented on BIT-1263:
-----------------------------------

Yeah, I would like to have test cases before merging this. Did you test the new 
messages in some form when you developed the code?

> Implementing three event handlers for supported data structure in Modbus 
> Analyzer
> ---------------------------------------------------------------------------------
>
>                 Key: BIT-1263
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1263
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: hui
>            Priority: Low
>              Labels: analyzer, modbus
>             Fix For: 2.4
>
>
> Three support data structures are defined in Modbus analyzer:
> FileRecordRequest,
> FileRecordResponse,
> ReferenceWithData
> Three event handlers are declared for them. 
> The changes are already made and pushed into the branch:
> topic/hui/modbus-events2



--
This message was sent by Atlassian JIRA
(v6.4-OD-16-006#64014)
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to